Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29372829: Issue 4833 - Enable translations for adblockpluscore (Closed)

Created:
Jan. 24, 2017, 11:13 a.m. by kzar
Modified:
Dec. 21, 2017, 12:37 p.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Issue 4833 - Enable translations for adblockpluscore

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed `-t generic` parameter, updated ensure_dependencies.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -99 lines) Patch
M README.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
A build.py View 1 chunk +18 lines, -0 lines 0 comments Download
M ensure_dependencies.py View 1 15 chunks +97 lines, -99 lines 0 comments Download
A metadata.generic View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
Jan. 24, 2017, 11:30 a.m. (2017-01-24 11:30:52 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29372829/diff/29372830/README.md File README.md (right): https://codereview.adblockplus.org/29372829/diff/29372830/README.md#newcode15 README.md:15: the command line. (You will also need the Crowdin ...
Jan. 24, 2017, 11:42 a.m. (2017-01-24 11:42:45 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29372829/diff/29372830/README.md File README.md (right): https://codereview.adblockplus.org/29372829/diff/29372830/README.md#newcode15 README.md:15: the command line. (You will also need the Crowdin ...
Jan. 24, 2017, 11:44 a.m. (2017-01-24 11:44:08 UTC) #3
kzar
Patch Set 2 : Removed `-t generic` parameter, updated ensure_dependencies.py https://codereview.adblockplus.org/29372829/diff/29372830/build.py File build.py (right): https://codereview.adblockplus.org/29372829/diff/29372830/build.py#newcode17 ...
Jan. 25, 2017, 3:54 a.m. (2017-01-25 03:54:19 UTC) #4
Wladimir Palant
Dec. 21, 2017, 10:39 a.m. (2017-12-21 10:39:23 UTC) #5
I'm reviewing myself from all reviews, making tlucas reviewer here in case that
change is still relevant.

Powered by Google App Engine
This is Rietveld