Issue 4833 - Enable translations for adblockpluscore

Issue 4833 - Enable translations for adblockpluscore

[kzar, 2017-01-24 11:30:52]

Patch Set 1

[Wladimir Palant, 2017-01-24 11:42:45]

https://codereview.adblockplus.org/29372829/diff/29372830/README.md
File README.md (right):

https://codereview.adblockplus.org/29372829/diff/29372830/README.md#newcode15
README.md:15: the command line. (You will also need the Crowdin API key for the
project.)
The -t generic parameter is optional because only one metadata file exists here.
I don't think we need it in the documentation.

Also, in the adblockplusui repository we called that script translate.py rather
than build.py because no actual builds can be generated here - only
translation-related commands are supported.

https://codereview.adblockplus.org/29372829/diff/29372830/build.py
File build.py (right):

https://codereview.adblockplus.org/29372829/diff/29372830/build.py#newcode17
build.py:17: import buildtools.build
This will fail - there is no buildtools dependency here yet. You should add the
dependency and ensure_dependencies.py script in the same commit, logically these
changes belong together.

[Wladimir Palant, 2017-01-24 11:44:08]

https://codereview.adblockplus.org/29372829/diff/29372830/README.md
File README.md (right):

https://codereview.adblockplus.org/29372829/diff/29372830/README.md#newcode15
README.md:15: the command line. (You will also need the Crowdin API key for the
project.)
On 2017/01/24 11:42:45, Wladimir Palant wrote:
> Also, in the adblockplusui repository we called that script translate.py
rather
> than build.py because no actual builds can be generated here - only
> translation-related commands are supported.

Please ignore this point, the script is actually called build.py in
adblockplusui repository as well. The optional parameter is pointless however,
I'll make sure it is removed in adblockplusui repository.

[kzar, 2017-01-25 03:54:19]

Patch Set 2 : Removed `-t generic` parameter, updated ensure_dependencies.py

https://codereview.adblockplus.org/29372829/diff/29372830/build.py
File build.py (right):

https://codereview.adblockplus.org/29372829/diff/29372830/build.py#newcode17
build.py:17: import buildtools.build
On 2017/01/24 11:42:45, Wladimir Palant wrote:
> This will fail - there is no buildtools dependency here yet. You 
> should add the dependency and ensure_dependencies.py script in the 
> same commit, logically these changes belong together.

I thought that too but it turns out there is already a dependencies file and
ensure_dependencies.py in the repository. Looking through the logs they were
added for #3618.

[Wladimir Palant, 2017-12-21 10:39:23]

I'm reviewing myself from all reviews, making tlucas reviewer here in case that
change is still relevant.