Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29374637: Issue 4549 - Implement the Windows Store API to upload development builds (Closed)

Created:
Feb. 6, 2017, 11:39 a.m. by Oleksandr
Modified:
Sept. 7, 2017, 11:08 p.m.
Visibility:
Public.

Description

Issue 4549 - Implement the Windows Store API to upload development builds

Patch Set 1 : Issue 4549 - Implement the Windows Store API to upload development builds #

Patch Set 2 : Add .sitescripts.example changes #

Total comments: 42

Patch Set 3 : Move to underscore notation. Simplify the networking code. Address comments. #

Total comments: 22

Patch Set 4 : Make sure response is always read. Address the nits. #

Patch Set 5 : Switch to urllib2 #

Total comments: 18

Patch Set 6 : Update buildtools. Remove submission update logic. Always close requests. #

Total comments: 4

Patch Set 7 : Address nits #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -27 lines) Patch
M .sitescripts.example View 1 1 chunk +10 lines, -0 lines 0 comments Download
M dependencies View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 1 2 3 4 5 4 chunks +15 lines, -16 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 4 5 6 9 chunks +131 lines, -8 lines 0 comments Download
M sitescripts/extensions/test/sitescripts.ini.template View 1 chunk +3 lines, -0 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M tox.ini View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20
Oleksandr
Feb. 6, 2017, 11:40 a.m. (2017-02-06 11:40:55 UTC) #1
Vasily Kuznetsov
Hi Ollie! Pretty impressive! Getting this to work must not have been a walk in ...
Feb. 7, 2017, 12:38 p.m. (2017-02-07 12:38:16 UTC) #2
Sebastian Noack
Thanks for having a go, Ollie! BTW, did you run "tox", which is the runner ...
Feb. 7, 2017, 1:54 p.m. (2017-02-07 13:54:43 UTC) #3
Vasily Kuznetsov
> Well, we did pretty much the same for the CrowdIn integration in the CMS. ...
Feb. 7, 2017, 3:05 p.m. (2017-02-07 15:05:26 UTC) #4
Oleksandr
On 2017/02/07 13:54:43, Sebastian Noack wrote: > BTW, did you run "tox", which is the ...
Feb. 9, 2017, 12:57 a.m. (2017-02-09 00:57:16 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode541 sitescripts/extensions/bin/createNightlies.py:541: method, url, body=None, headers={}): Using mutable types as default ...
Feb. 9, 2017, 12:51 p.m. (2017-02-09 12:51:58 UTC) #6
Vasily Kuznetsov
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode544 sitescripts/extensions/bin/createNightlies.py:544: if (response.status >= 300): On 2017/02/09 12:51:57, Sebastian Noack ...
Feb. 9, 2017, 4:37 p.m. (2017-02-09 16:37:59 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode544 sitescripts/extensions/bin/createNightlies.py:544: if (response.status >= 300): On 2017/02/09 16:37:58, Vasily Kuznetsov ...
Feb. 9, 2017, 8:50 p.m. (2017-02-09 20:50:23 UTC) #8
Vasily Kuznetsov
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode547 sitescripts/extensions/bin/createNightlies.py:547: return response.read().decode() On 2017/02/09 20:50:23, Sebastian Noack wrote: > ...
Feb. 9, 2017, 9:01 p.m. (2017-02-09 21:01:55 UTC) #9
Oleksandr
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode541 sitescripts/extensions/bin/createNightlies.py:541: method, url, body=None, headers={}): On 2017/02/09 12:51:57, Sebastian Noack ...
Feb. 13, 2017, 2:57 a.m. (2017-02-13 02:57:37 UTC) #10
Vasily Kuznetsov
Hi Ollie and Sebastian, It looks like everything is pretty much settled except for the ...
Feb. 13, 2017, 10:44 a.m. (2017-02-13 10:44:14 UTC) #11
Sebastian Noack
https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29374887/sitescripts/extensions/bin/createNightlies.py#newcode544 sitescripts/extensions/bin/createNightlies.py:544: if (response.status >= 300): On 2017/02/13 02:57:36, Oleksandr wrote: ...
Feb. 14, 2017, 12:36 p.m. (2017-02-14 12:36:00 UTC) #12
Oleksandr
Patch Set: Switch to urllib2
Feb. 15, 2017, 3:42 a.m. (2017-02-15 03:42:55 UTC) #13
Sebastian Noack
https://codereview.adblockplus.org/29374637/diff/29375717/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (left): https://codereview.adblockplus.org/29374637/diff/29375717/sitescripts/extensions/bin/createNightlies.py#oldcode28 sitescripts/extensions/bin/createNightlies.py:28: from datetime import datetime Thanks for getting rid of ...
Feb. 15, 2017, 11:20 a.m. (2017-02-15 11:20:05 UTC) #14
Oleksandr
Patch set 6. Also updated buildtools to include #4865. https://codereview.adblockplus.org/29374637/diff/29375717/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (left): https://codereview.adblockplus.org/29374637/diff/29375717/sitescripts/extensions/bin/createNightlies.py#oldcode28 sitescripts/extensions/bin/createNightlies.py:28: ...
Feb. 16, 2017, 7:13 a.m. (2017-02-16 07:13:13 UTC) #15
Sebastian Noack
https://codereview.adblockplus.org/29374637/diff/29375818/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29374637/diff/29375818/sitescripts/extensions/bin/createNightlies.py#newcode542 sitescripts/extensions/bin/createNightlies.py:542: auth_token = '' Defining auth_token here seems redundant. https://codereview.adblockplus.org/29374637/diff/29375818/sitescripts/extensions/bin/createNightlies.py#newcode564 ...
Feb. 16, 2017, 11:01 a.m. (2017-02-16 11:01:13 UTC) #16
Oleksandr
Feb. 16, 2017, 1:06 p.m. (2017-02-16 13:06:22 UTC) #17
Sebastian Noack
Looks basically good to me. However, I cannot cleanly apply the patch on top of ...
Feb. 16, 2017, 1:12 p.m. (2017-02-16 13:12:21 UTC) #18
Oleksandr
Rebased
Feb. 16, 2017, 1:15 p.m. (2017-02-16 13:15:25 UTC) #19
Sebastian Noack
Feb. 16, 2017, 1:31 p.m. (2017-02-16 13:31:05 UTC) #20

Powered by Google App Engine
This is Rietveld