Issue 4864 - Start using ESLint for adblockpluschrome

composer.js

Index: composer.js
diff --git a/composer.js b/composer.js
index 6c54eff99dd0775af4f9262f61defc7be4dd1ad7..0bc787349215f7e14b70e2d55cf56753cb6b27ab 100644
--- a/composer.js
+++ b/composer.js
@@ -15,6 +15,8 @@
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* globals $ */

[Sebastian Noack, 2017/02/09 01:04:50]

I guess we should rather enable the "jquery" environment, than whitelisting "$"
explicitly, if it is just to avoid confusion with Chrome's built-in "$".

Also I'm not too happy with the inline configurations spread across our code. I
wonder whether it would be worth to add the "jQuery" environment to the global
configuration. On the other hand, it's not available in all files. But then
again, this is also true for some of the other environments configured globally,
and this isn't the only file using jQuery either.

[kzar, 2017/02/20 10:27:30]

IMO explicitly adding global comments at the top of relevant files like this
isn't too big a deal, and as Wladimir pointed out they are actually useful as
they act as documentation of the global variables in the code for humans too.

That said I don't have a strong opinion about if `/* globals $ */` or `/*
eslint-env jquery */` looks nicer here, so up to you I guess.

I think adding the jQuery environment globally to the configuration would be a
footgun since like you say those variables aren't available throughout. So the
fact the configuration implied they were would be misleading and also we would
lose some of the benefit of using the no-undef rule in the process.

+
 "use strict";
 
 let targetPageId = null;
@@ -35,8 +37,7 @@ function onKeyDown(event)
 
 function addFilters()
 {
-  ext.backgroundPage.sendMessage(
-  {
+  ext.backgroundPage.sendMessage({
     type: "filters.importRaw",
     text: document.getElementById("filters").value
   },
@@ -51,10 +52,9 @@ function addFilters()
 
 function closeDialog(success)
 {
-  ext.backgroundPage.sendMessage(
-  {
+  ext.backgroundPage.sendMessage({
     type: "forward",
-    targetPageId: targetPageId,
+    targetPageId,
     payload:
     {
       type: "composer.content.finished",