Issue 4882 - Adapted link for flake8-abp to flake8-eyeo renaming, and added missing <fix> tags

Issue 4882 - Adapted link for flake8-abp to flake8-eyeo renaming, and added missing <fix> tags

[Sebastian Noack, 2017-02-13 13:23:34]

While on it, I also added some missing <fix> tags in the Python section. The
<fix> tag makes sure that the text inside does not get translated, and therefore
should be used for any fixed names like here.

[saroyanm, 2017-02-13 13:41:57]

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
File pages/coding-style.html (right):

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:56: <li>{{python-general Follow <a
href="https://www.python.org/dev/peps/pep-0008/"><fix>PEP-8</fix></a> and the
recommendations in the offical Python documentation.}}</li>
Fix suggestions:
<fix>Python</fix>

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:57: <li>{{python-version Make the code compatible with
both Python 2.7 and Python 3.5+ (see <a
href="https://docs.python.org/dev/howto/pyporting.html">this guide</a>). Use <a
href="https://docs.python.org/2/library/__future__.html"><fix>__future__</fix>
imports</a> to address syntactic differences but avoid <a
href="https://pythonhosted.org/six/"><fix>six</fix></a>, <a
href="http://python-future.org/compatible_idioms.html"><fix>python-future</fix></a>,
etc. to not introduce additional dependencies.}}</li>
Fix suggestions:
<fix>Python 2.7</fix> and <fix>Python 3.5+</fix>

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:66: <li>{{python-tests Write tests and have them run
along flake8 using <a
href="https://pypi.python.org/pypi/tox"><fix>tox</fix></a>.}}</li>
Fix suggestions:
<fix>flake8</fix>

[Sebastian Noack, 2017-02-13 13:57:26]

Well spotted. I added the addional <fix> tags. I also just noticed that the
programming languages are mistakenly translated in the headings. However, I feel
correcting this is out of scope here, but should rather be done with a separate
patch.

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
File pages/coding-style.html (right):

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:56: <li>{{python-general Follow <a
href="https://www.python.org/dev/peps/pep-0008/"><fix>PEP-8</fix></a> and the
recommendations in the offical Python documentation.}}</li>
On 2017/02/13 13:41:56, saroyanm wrote:
> Fix suggestions:
> <fix>Python</fix>

Done.

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:57: <li>{{python-version Make the code compatible with
both Python 2.7 and Python 3.5+ (see <a
href="https://docs.python.org/dev/howto/pyporting.html">this guide</a>). Use <a
href="https://docs.python.org/2/library/__future__.html"><fix>__future__</fix>
imports</a> to address syntactic differences but avoid <a
href="https://pythonhosted.org/six/"><fix>six</fix></a>, <a
href="http://python-future.org/compatible_idioms.html"><fix>python-future</fix></a>,
etc. to not introduce additional dependencies.}}</li>
On 2017/02/13 13:41:56, saroyanm wrote:
> Fix suggestions:
> <fix>Python 2.7</fix> and <fix>Python 3.5+</fix>

Done.

https://codereview.adblockplus.org/29375654/diff/29375655/pages/coding-style....
pages/coding-style.html:66: <li>{{python-tests Write tests and have them run
along flake8 using <a
href="https://pypi.python.org/pypi/tox"><fix>tox</fix></a>.}}</li>
On 2017/02/13 13:41:56, saroyanm wrote:
> Fix suggestions:
> <fix>flake8</fix>

Done.

[saroyanm, 2017-02-13 14:05:06]

considering that this change will be pushed after the
https://hg.adblockplus.org/codingtools/file/tip/flake8-eyeo link will be
available: LGTM

[Jon Sonesen, 2017-02-13 14:05:28]

On 2017/02/13 14:05:06, saroyanm wrote:
> considering that this change will be pushed after the
> https://hg.adblockplus.org/codingtools/file/tip/flake8-eyeo link will be
> available: LGTM

LGTM