Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375722: Noissue - Update the JavaScript coding style guide regarding ESLint (Closed)

Created:
Feb. 15, 2017, 5:14 a.m. by kzar
Modified:
Feb. 17, 2017, 7:32 a.m.
Visibility:
Public.

Description

Noissue - Update the JavaScript coding style guide regarding ESLint See https://codereview.adblockplus.org/29374555/diff/29375587/eslint-config-eyeo/index.js#newcode38

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Sebastian's feedback #

Total comments: 2

Patch Set 3 : Reworded new spacing rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pages/coding-style.html View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
kzar
Patch Set 1
Feb. 15, 2017, 5:16 a.m. (2017-02-15 05:16:16 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style.html File pages/coding-style.html (left): https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style.html#oldcode32 pages/coding-style.html:32: <ul> While on it, mind adding a point to ...
Feb. 15, 2017, 10:43 a.m. (2017-02-15 10:43:06 UTC) #2
kzar
Patch Set 2 : Addressed Sebastian's feedback Note: I updated the name of this review ...
Feb. 15, 2017, 11:22 a.m. (2017-02-15 11:22:36 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style.html#newcode31 pages/coding-style.html:31: <li>{{javascript-spacing-literals Don't add spaces directly inside of Object and ...
Feb. 15, 2017, 11:34 a.m. (2017-02-15 11:34:45 UTC) #4
kzar
Patch Set 3 : Reworded new spacing rule https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style.html#newcode31 pages/coding-style.html:31: <li>{{javascript-spacing-literals ...
Feb. 15, 2017, 11:48 a.m. (2017-02-15 11:48:55 UTC) #5
Sebastian Noack
LGTM. Just make sure to first land the changes to codingtools, in order to avoid ...
Feb. 15, 2017, 12:05 p.m. (2017-02-15 12:05:40 UTC) #6
Felix Dahlke
Feb. 15, 2017, 4:02 p.m. (2017-02-15 16:02:43 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld