Noissue - Update the JavaScript coding style guide regarding ESLint

Noissue - Update the JavaScript coding style guide regarding ESLint

See https://codereview.adblockplus.org/29374555/diff/29375587/eslint-config-eyeo/index.js#newcode38

[kzar, 2017-02-15 05:16:16]

Patch Set 1

[Sebastian Noack, 2017-02-15 10:43:06]

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
File pages/coding-style.html (left):

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
pages/coding-style.html:32: <ul>
While on it, mind adding a point to refer to eslint and eslint-config-eyeo. For
reference, this is what we have in the Python section:

  Run flake8 with the flake8-eyeo and pep8-naming extensions
  and fix any warning.

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
pages/coding-style.html:32: <ul>
We probably also should add a point to clarify that we don't use spacing in
object and array literals, in particular since our practice (as enforced by
eslint-config-eyeo) is in conflict with Mozilla's coding practices which we
refer to here.

[kzar, 2017-02-15 11:22:36]

Patch Set 2 : Addressed Sebastian's feedback

Note: I updated the name of this review since the old name is no longer
accurate.

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
File pages/coding-style.html (left):

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
pages/coding-style.html:32: <ul>
On 2017/02/15 10:43:06, Sebastian Noack wrote:
> While on it, mind adding a point to refer to eslint and eslint-config-eyeo.
For
> reference, this is what we have in the Python section:
> 
>   Run flake8 with the flake8-eyeo and pep8-naming extensions
>   and fix any warning.

Done.

https://codereview.adblockplus.org/29375722/diff/29375723/pages/coding-style....
pages/coding-style.html:32: <ul>
On 2017/02/15 10:43:06, Sebastian Noack wrote:
> We probably also should add a point to clarify that we don't use spacing in
> object and array literals, in particular since our practice (as enforced by
> eslint-config-eyeo) is in conflict with Mozilla's coding practices which we
> refer to here.

Done.

[Sebastian Noack, 2017-02-15 11:34:45]

https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style....
File pages/coding-style.html (right):

https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style....
pages/coding-style.html:31: <li>{{javascript-spacing-literals Don't add spaces
directly inside of Object and Array literals.}}</li>
I don't think that Object and Array need to be capitalized. Also I find it a
little bit unclear where no spaces should be used. We are only talking about
spaces after opning or before closing the literal. {foo: 1} or [1, 2] would be
ok (actually the spaces there are desired), { foo } or [ 1 ] is not ok, but both
use spaces. How about this:

  Don't add any spaces immediately after opening, or before closing,
  an object or array literal.

[kzar, 2017-02-15 11:48:55]

Patch Set 3 : Reworded new spacing rule

https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style....
File pages/coding-style.html (right):

https://codereview.adblockplus.org/29375722/diff/29375793/pages/coding-style....
pages/coding-style.html:31: <li>{{javascript-spacing-literals Don't add spaces
directly inside of Object and Array literals.}}</li>
On 2017/02/15 11:34:45, Sebastian Noack wrote:
> I don't think that Object and Array need to be capitalized. Also I find it a
> little bit unclear where no spaces should be used. We are only talking about
> spaces after opning or before closing the literal. {foo: 1} or [1, 2] would be
> ok (actually the spaces there are desired), { foo } or [ 1 ] is not ok, but
both
> use spaces. How about this:
> 
>   Don't add any spaces immediately after opening, or before closing,
>   an object or array literal.

Yea I found this rule hard to word and I think your wording is much better.
Done.

[Sebastian Noack, 2017-02-15 12:05:40]

LGTM. Just make sure to first land the changes to codingtools, in order to avoid
broken links on the website.

[Felix Dahlke, 2017-02-15 16:02:43]

LGTM