Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375809: Issue 4830 - Changed FairCompany logo on eyeo.com/jobs (Closed)

Created:
Feb. 15, 2017, 3:16 p.m. by erick
Modified:
July 12, 2017, 9:06 a.m.
Reviewers:
juliandoucette, ire
CC:
saroyanm
Visibility:
Public.

Description

Issue 4830 - Changed FairCompany logo on eyeo.com/jobs

Patch Set 1 #

Total comments: 2

Patch Set 2 : Scaled the image to an optimized size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M includes/jobs/header.tmpl View 1 chunk +1 line, -1 line 0 comments Download
D static/images/fair-company.jpg View Binary file 0 comments Download
A static/images/fair-company.png View 1 Binary file 0 comments Download

Messages

Total messages: 8
saroyanm
https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl File includes/jobs/header.tmpl (right): https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl#newcode48 includes/jobs/header.tmpl:48: <img id="fair-company-logo" src="/images/fair-company.png" alt="Fair Company" height="80"> The image itself ...
Feb. 22, 2017, 1:24 p.m. (2017-02-22 13:24:38 UTC) #1
erick
On 2017/02/22 13:24:38, saroyanm wrote: > https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl > File includes/jobs/header.tmpl (right): > > https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl#newcode48 > ...
Feb. 27, 2017, 1:23 p.m. (2017-02-27 13:23:38 UTC) #2
erick
https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl File includes/jobs/header.tmpl (right): https://codereview.adblockplus.org/29375809/diff/29375810/includes/jobs/header.tmpl#newcode48 includes/jobs/header.tmpl:48: <img id="fair-company-logo" src="/images/fair-company.png" alt="Fair Company" height="80"> On 2017/02/22 13:24:38, ...
Feb. 28, 2017, 12:48 p.m. (2017-02-28 12:48:33 UTC) #3
saroyanm
Changed the reviewer.
May 22, 2017, 11:59 a.m. (2017-05-22 11:59:38 UTC) #4
ire
On 2017/02/28 12:48:33, erick wrote: > > On 2017/02/22 13:24:38, saroyanm wrote: > > The ...
May 23, 2017, 12:07 a.m. (2017-05-23 00:07:15 UTC) #5
juliandoucette
On 2017/05/23 00:07:15, ire wrote: > On 2017/02/28 12:48:33, erick wrote: > > > > ...
June 14, 2017, 12:26 p.m. (2017-06-14 12:26:21 UTC) #6
ire
On 2017/06/14 12:26:21, juliandoucette wrote: > I went ahead and implemented and pushed this myself. ...
June 14, 2017, 1:47 p.m. (2017-06-14 13:47:29 UTC) #7
juliandoucette
June 16, 2017, 5:40 p.m. (2017-06-16 17:40:24 UTC) #8
Can you close this issue please Erick?

Powered by Google App Engine
This is Rietveld