Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(301)

Issue 29375829: Issue 4899 - set template META description on eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by erick
Modified:
2 years, 10 months ago
Visibility:
Public.

Description

Issue 4899 - set template META description on eyeo.com

Patch Set 1 #

Total comments: 4

Patch Set 2 : Deleted the include and added to the default template #

Total comments: 6

Patch Set 3 : Deleted META-title and changed META-description #

Patch Set 4 : Deleted Space and added slash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M templates/default.tmpl View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8
erick
2 years, 11 months ago (2017-02-16 11:45:16 UTC) #1
juliandoucette
Please include which website is being changed in the subject. Also: - eyeo.com is not ...
2 years, 10 months ago (2017-02-21 15:20:14 UTC) #2
saroyanm
Small addition to Julian's comments. https://codereview.adblockplus.org/29375829/diff/29375830/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29375829/diff/29375830/templates/default.tmpl#newcode4 templates/default.tmpl:4: <? include meta ?> ...
2 years, 10 months ago (2017-02-22 13:10:47 UTC) #3
erick
On 2017/02/22 13:10:47, saroyanm wrote: > Small addition to Julian's comments. > > https://codereview.adblockplus.org/29375829/diff/29375830/templates/default.tmpl > ...
2 years, 10 months ago (2017-02-28 12:37:42 UTC) #4
erick
https://codereview.adblockplus.org/29375829/diff/29375830/includes/meta.tmpl File includes/meta.tmpl (right): https://codereview.adblockplus.org/29375829/diff/29375830/includes/meta.tmpl#newcode7 includes/meta.tmpl:7: <meta name="title" content="{{ title | translate('page-title', 'Page Title') }}"> ...
2 years, 10 months ago (2017-02-28 12:46:41 UTC) #5
saroyanm
https://codereview.adblockplus.org/29375829/diff/29377558/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29375829/diff/29377558/templates/default.tmpl#newcode5 templates/default.tmpl:5: <meta charset="utf-8"> It's uppercase UTF-8 -> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-charset https://codereview.adblockplus.org/29375829/diff/29377558/templates/default.tmpl#newcode10 templates/default.tmpl:10: ...
2 years, 10 months ago (2017-02-28 17:24:58 UTC) #6
erick
https://codereview.adblockplus.org/29375829/diff/29377558/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29375829/diff/29377558/templates/default.tmpl#newcode5 templates/default.tmpl:5: <meta charset="utf-8"> On 2017/02/28 17:24:58, saroyanm wrote: > It's ...
2 years, 10 months ago (2017-03-01 11:29:40 UTC) #7
saroyanm
2 years, 10 months ago (2017-03-08 11:16:26 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5