Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375851: [safari] Issue 4902 - Partially revert d5be57b68f91 for Safari compatibility (Closed)

Created:
Feb. 17, 2017, 9:31 a.m. by kzar
Modified:
Feb. 17, 2017, 4:01 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

[safari] Issue 4902 - Partially revert d5be57b68f91 for Safari compatibility

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Sebastian's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+956 lines, -4 lines) Patch
A lib/jsbn.js View 1 chunk +587 lines, -0 lines 0 comments Download
A lib/rsa.js View 1 chunk +193 lines, -0 lines 0 comments Download
A lib/sha1.js View 1 chunk +173 lines, -0 lines 0 comments Download
M lib/whitelisting.js View 1 chunk +0 lines, -1 line 0 comments Download
M metadata.common View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Feb. 17, 2017, 9:37 a.m. (2017-02-17 09:37:32 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29375851/diff/29375852/metadata.common File metadata.common (right): https://codereview.adblockplus.org/29375851/diff/29375852/metadata.common#newcode12 metadata.common:12: lib/sha1.js Perhaps, add a comment here, at least, explaining ...
Feb. 17, 2017, 11:59 a.m. (2017-02-17 11:59:20 UTC) #2
kzar
Patch Set 2 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29375851/diff/29375852/metadata.common File metadata.common (right): https://codereview.adblockplus.org/29375851/diff/29375852/metadata.common#newcode12 metadata.common:12: lib/sha1.js On ...
Feb. 17, 2017, 2:17 p.m. (2017-02-17 14:17:25 UTC) #3
Sebastian Noack
Feb. 17, 2017, 2:35 p.m. (2017-02-17 14:35:41 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld