Issue 29377054: Issue 4942 - Failed to build due to "sorry, unimplemented: mangling dotstar_expr" (Closed)
|
Created:
Feb. 28, 2017, 8:48 a.m. by anton Modified:
March 21, 2017, 10:12 a.m. CC:
Felix Dahlke Visibility:
Public. |
DescriptionIssue 4942 - Failed to build due to "sorry, unimplemented: mangling dotstar_expr"
Patch Set 1 #
Total comments: 5
Patch Set 2 : using gcc 4.9 #MessagesTotal messages: 13
https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... File libadblockplus-android/jni/Application.mk (right): https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 we could just use clang but since libadblockplus uses gcc i believe we should prefer gcc 4.8 to clang
https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... File libadblockplus-android/jni/Application.mk (right): https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 BTW i've just found that `clang` is used to build libadblockplus: https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 what toolchain should we prefer now?
https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... File libadblockplus-android/jni/Application.mk (right): https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 On 2017/03/13 10:11:47, anton wrote: > BTW i've just found that `clang` is used to build libadblockplus: > https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 > > what toolchain should we prefer now? Since we're using clang on libadblockplus and gcc is now deprecated, I would go for using clang, but no strong opinion about that
https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... File libadblockplus-android/jni/Application.mk (right): https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 On 2017/03/13 14:25:56, diegocarloslima wrote: > On 2017/03/13 10:11:47, anton wrote: > > BTW i've just found that `clang` is used to build libadblockplus: > > https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 > > > > what toolchain should we prefer now? > > Since we're using clang on libadblockplus and gcc is now deprecated, I would go > for using clang, but no strong opinion about that gcc is deprecated in the recent android NDK but our next version of v8 is using gcc when it's built for arm. I would suggest to use the same gcc everywhere for present and switch to clang when it's done in v8.
https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... File libadblockplus-android/jni/Application.mk (right): https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 BTW, I have just checked: currently v8 is compiled by g++-4.6 for both arm and android-x86, libadblockplus - clang3.4, ndk 10d. The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b and I plan to use the same g++ for libadblockplus. Does version 4.8 actually work for you currently?
On 2017/03/13 15:40:19, sergei wrote: > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > File libadblockplus-android/jni/Application.mk (right): > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 > BTW, I have just checked: > > currently v8 is compiled by g++-4.6 for both arm and android-x86, libadblockplus > - clang3.4, ndk 10d. > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b and I > plan to use the same g++ for libadblockplus. > > Does version 4.8 actually work for you currently? Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 is replaced with new versions and is missing in newer android ndk we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are working for libadblockplus-android.
On 2017/03/14 04:08:50, anton wrote: > On 2017/03/13 15:40:19, sergei wrote: > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > File libadblockplus-android/jni/Application.mk (right): > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 > > BTW, I have just checked: > > > > currently v8 is compiled by g++-4.6 for both arm and android-x86, > libadblockplus > > - clang3.4, ndk 10d. > > > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b and > I > > plan to use the same g++ for libadblockplus. > > > > Does version 4.8 actually work for you currently? > > Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 is > replaced with new versions and is missing in newer android ndk > we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are working > for libadblockplus-android. Shouldn't we change it to 4.9 then to be consistent with the next release?
On 2017/03/16 19:43:23, diegocarloslima wrote: > On 2017/03/14 04:08:50, anton wrote: > > On 2017/03/13 15:40:19, sergei wrote: > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > File libadblockplus-android/jni/Application.mk (right): > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 > > > BTW, I have just checked: > > > > > > currently v8 is compiled by g++-4.6 for both arm and android-x86, > > libadblockplus > > > - clang3.4, ndk 10d. > > > > > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b > and > > I > > > plan to use the same g++ for libadblockplus. > > > > > > Does version 4.8 actually work for you currently? > > > > Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 is > > replaced with new versions and is missing in newer android ndk > > we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are > working > > for libadblockplus-android. > Sergei? > Shouldn't we change it to 4.9 then to be consistent with the next release?
On 2017/03/17 10:21:58, anton wrote: > On 2017/03/16 19:43:23, diegocarloslima wrote: > > On 2017/03/14 04:08:50, anton wrote: > > > On 2017/03/13 15:40:19, sergei wrote: > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > File libadblockplus-android/jni/Application.mk (right): > > > > > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := 4.8 > > > > BTW, I have just checked: > > > > > > > > currently v8 is compiled by g++-4.6 for both arm and android-x86, > > > libadblockplus > > > > - clang3.4, ndk 10d. > > > > > > > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b > > and > > > I > > > > plan to use the same g++ for libadblockplus. > > > > > > > > Does version 4.8 actually work for you currently? > > > > > > Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 is > > > replaced with new versions and is missing in newer android ndk > > > we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are > > working > > > for libadblockplus-android. > > > > Sergei? > > > Shouldn't we change it to 4.9 then to be consistent with the next release? If it works then yes.
On 2017/03/17 10:24:46, sergei wrote: > On 2017/03/17 10:21:58, anton wrote: > > On 2017/03/16 19:43:23, diegocarloslima wrote: > > > On 2017/03/14 04:08:50, anton wrote: > > > > On 2017/03/13 15:40:19, sergei wrote: > > > > > > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > > File libadblockplus-android/jni/Application.mk (right): > > > > > > > > > > > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := > 4.8 > > > > > BTW, I have just checked: > > > > > > > > > > currently v8 is compiled by g++-4.6 for both arm and android-x86, > > > > libadblockplus > > > > > - clang3.4, ndk 10d. > > > > > > > > > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk > 12b > > > and > > > > I > > > > > plan to use the same g++ for libadblockplus. > > > > > > > > > > Does version 4.8 actually work for you currently? > > > > > > > > Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 is > > > > replaced with new versions and is missing in newer android ndk > > > > we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are > > > working > > > > for libadblockplus-android. > > > > > > > Sergei? > > > > > Shouldn't we change it to 4.9 then to be consistent with the next release? > If it works then yes. Updated to use 4.9 and checked - i was able to compile
On 2017/03/17 10:35:35, anton wrote: > On 2017/03/17 10:24:46, sergei wrote: > > On 2017/03/17 10:21:58, anton wrote: > > > On 2017/03/16 19:43:23, diegocarloslima wrote: > > > > On 2017/03/14 04:08:50, anton wrote: > > > > > On 2017/03/13 15:40:19, sergei wrote: > > > > > > > > > > > > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > > > File libadblockplus-android/jni/Application.mk (right): > > > > > > > > > > > > > > > > > > > > > > > > > > > https://codereview.adblockplus.org/29377054/diff/29377055/libadblockplus-andr... > > > > > > libadblockplus-android/jni/Application.mk:5: NDK_TOOLCHAIN_VERSION := > > 4.8 > > > > > > BTW, I have just checked: > > > > > > > > > > > > currently v8 is compiled by g++-4.6 for both arm and android-x86, > > > > > libadblockplus > > > > > > - clang3.4, ndk 10d. > > > > > > > > > > > > The next version of v8 will use g++-4.9 for both arm android-x86, ndk > > 12b > > > > and > > > > > I > > > > > > plan to use the same g++ for libadblockplus. > > > > > > > > > > > > Does version 4.8 actually work for you currently? > > > > > > > > > > Yes, i've checked and both gcc 4.8 and clang are working. Since gcc 4.6 > is > > > > > replaced with new versions and is missing in newer android ndk > > > > > we have to avoid gcc 4.6 anyway. I've just checked both 4.8 and 4.9 are > > > > working > > > > > for libadblockplus-android. > > > > > > > > > > Sergei? > > > > > > > Shouldn't we change it to 4.9 then to be consistent with the next release? > > If it works then yes. > > Updated to use 4.9 and checked - i was able to compile LGTM
LGTM 
|
