Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29377728: Issue 4866 - Add the child-src CSP directive back again for now (Closed)

Created:
March 1, 2017, 10:32 a.m. by kzar
Modified:
March 2, 2017, 4:11 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 4866 - Add the child-src CSP directive back again for now

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep frame-src too, just in case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/csp.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
March 1, 2017, 10:41 a.m. (2017-03-01 10:41:44 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29377728/diff/29377729/lib/csp.js File lib/csp.js (right): https://codereview.adblockplus.org/29377728/diff/29377729/lib/csp.js#newcode47 lib/csp.js:47: value: "connect-src http:; child-src http:; object-src http:" 1.12.4 was ...
March 1, 2017, 1:17 p.m. (2017-03-01 13:17:58 UTC) #2
kzar
Patch Set 2 : Keep frame-src too, just in case https://codereview.adblockplus.org/29377728/diff/29377729/lib/csp.js File lib/csp.js (right): https://codereview.adblockplus.org/29377728/diff/29377729/lib/csp.js#newcode47 ...
March 1, 2017, 2:41 p.m. (2017-03-01 14:41:18 UTC) #3
Wladimir Palant
March 1, 2017, 4:55 p.m. (2017-03-01 16:55:57 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld