Issue 4981 - Adds test coverage report

Issue 4981 - Adds test coverage report

[Wladimir Palant, 2017-03-16 10:51:59]

I'm moving myself to Cc, not my area of expertise.

[Vasily Kuznetsov, 2017-03-17 11:58:42]

Hey Jon,

What do you think about also adding an environment that would generate an HTML
coverage report. Something along the lines of:

[testenv:htmlcov]
commands = py.test --cov-report html --cov=cms tests

And also add "htmlcov" directory to ignores.

The HTML report is quite useful for quickly assessing whether the lines you have
changed have test coverage.

Otherwise it looks good.

Cheers,
Vasily

[Jon Sonesen, 2017-03-17 12:21:00]

On 2017/03/17 11:58:42, Vasily Kuznetsov wrote:
> Hey Jon,
> 
> What do you think about also adding an environment that would generate an HTML
> coverage report. Something along the lines of:
> 
> [testenv:htmlcov]
> commands = py.test --cov-report html --cov=cms tests
> 
> And also add "htmlcov" directory to ignores.
> 
> The HTML report is quite useful for quickly assessing whether the lines you
have
> changed have test coverage.
> 
> Otherwise it looks good.
> 
> Cheers,
> Vasily

Hey Vasily,

That's a good idea, I will do this :)

[Vasily Kuznetsov, 2017-03-17 17:29:57]

On 2017/03/17 12:21:00, Jon Sonesen wrote:
> On 2017/03/17 11:58:42, Vasily Kuznetsov wrote:
> > Hey Jon,
> > 
> > What do you think about also adding an environment that would generate an
HTML
> > coverage report. Something along the lines of:
> > 
> > [testenv:htmlcov]
> > commands = py.test --cov-report html --cov=cms tests
> > 
> > And also add "htmlcov" directory to ignores.
> > 
> > The HTML report is quite useful for quickly assessing whether the lines you
> have
> > changed have test coverage.
> > 
> > Otherwise it looks good.
> > 
> > Cheers,
> > Vasily
> 
> Hey Vasily,
> 
> That's a good idea, I will do this :)

I see, you put it into the main test run instead of making it a separate tox
environment. That's probably even better.

What about also modifying .gitignore for our friends who mostly use git?

[Jon Sonesen, 2017-03-18 09:19:00]

On 2017/03/17 17:29:57, Vasily Kuznetsov wrote:
> On 2017/03/17 12:21:00, Jon Sonesen wrote:
> > On 2017/03/17 11:58:42, Vasily Kuznetsov wrote:
> > > Hey Jon,
> > > 
> > > What do you think about also adding an environment that would generate an
> HTML
> > > coverage report. Something along the lines of:
> > > 
> > > [testenv:htmlcov]
> > > commands = py.test --cov-report html --cov=cms tests
> > > 
> > > And also add "htmlcov" directory to ignores.
> > > 
> > > The HTML report is quite useful for quickly assessing whether the lines
you
> > have
> > > changed have test coverage.
> > > 
> > > Otherwise it looks good.
> > > 
> > > Cheers,
> > > Vasily
> > 
> > Hey Vasily,
> > 
> > That's a good idea, I will do this :)
> 
> I see, you put it into the main test run instead of making it a separate tox
> environment. That's probably even better.
> 
> What about also modifying .gitignore for our friends who mostly use git?

No problem!

[Vasily Kuznetsov, 2017-03-18 14:20:09]

https://codereview.adblockplus.org/29383956/diff/29387555/.gitignore
File .gitignore (right):

https://codereview.adblockplus.org/29383956/diff/29387555/.gitignore#newcode7
.gitignore:7: /.coverage/
Wouldn't the slash at the end of "/.coverage/" cause the file "/.coverage" to
not match?

[Jon Sonesen, 2017-03-18 15:38:07]

https://codereview.adblockplus.org/29383956/diff/29387555/.gitignore
File .gitignore (right):

https://codereview.adblockplus.org/29383956/diff/29387555/.gitignore#newcode7
.gitignore:7: /.coverage/
On 2017/03/18 14:20:09, Vasily Kuznetsov wrote:
> Wouldn't the slash at the end of "/.coverage/" cause the file "/.coverage" to
> not match?

yeah sorry

[Vasily Kuznetsov, 2017-03-20 09:12:39]

LGTM