Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29384555: Issue 4978 - Avoid custom filters from being displayed multiple times (Closed)

Created:
March 15, 2017, 7:24 a.m. by kzar
Modified:
April 28, 2017, 9:17 a.m.
Visibility:
Public.

Description

Issue 4978 - Avoid custom filters from being displayed multiple times Based upon the changes in https://codereview.adblockplus.org/29374674/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M options.js View 5 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
March 15, 2017, 7:25 a.m. (2017-03-15 07:25:50 UTC) #1
Sebastian Noack
Wouldn't it be sufficient, but much simpler, to just clear the <select> boxes, before adding ...
March 29, 2017, 2:18 p.m. (2017-03-29 14:18:41 UTC) #2
Wladimir Palant
On 2017/03/29 14:18:41, Sebastian Noack wrote: > Wouldn't it be sufficient, but much simpler, to ...
March 29, 2017, 2:23 p.m. (2017-03-29 14:23:46 UTC) #3
Sebastian Noack
I see. Perhaps we should rather change the message responder then, in order to send ...
March 29, 2017, 2:29 p.m. (2017-03-29 14:29:27 UTC) #4
Wladimir Palant
March 29, 2017, 2:45 p.m. (2017-03-29 14:45:59 UTC) #5
On 2017/03/29 14:29:27, Sebastian Noack wrote:
> I see. Perhaps we should rather change the message responder then, in order to
> send the filters along, when reporting that a special subscription has been
> added, eliminating the asynchronous race condition in the first place, rather
> than working around it.

That's what I suggested as well, we shouldn't break up the state like this.

Powered by Google App Engine
This is Rietveld