Issue 4978 - Avoid custom filters from being displayed multiple times

Issue 4978 - Avoid custom filters from being displayed multiple times

Based upon the changes in https://codereview.adblockplus.org/29374674/

[kzar, 2017-03-15 07:25:50]

Patch Set 1

[Sebastian Noack, 2017-03-29 14:18:41]

Wouldn't it be sufficient, but much simpler, to just clear the <select> boxes,
before adding the filters retrieved for the special subscription?

  function convertSpecialSubscription(subscription)
  {
    getFilters(subscription.url, filters =>
    {
      document.getElementById("excludedDomainsBox").innerHTML = "":
      document.getElementById("userFiltersBox").innerHTML = "":

      for (let filter of filters)
      {
        if (whitelistedDomainRegexp.test(filter.text))
          appendToListBox("excludedDomainsBox", RegExp.$1);
        else
          appendToListBox("userFiltersBox", filter.text);
      }
    });
  }

[Wladimir Palant, 2017-03-29 14:23:46]

On 2017/03/29 14:18:41, Sebastian Noack wrote:
> Wouldn't it be sufficient, but much simpler, to just clear the <select> boxes,
> before adding the filters retrieved for the special subscription?

No, there can be more than one special subscription.

[Sebastian Noack, 2017-03-29 14:29:27]

I see. Perhaps we should rather change the message responder then, in order to
send the filters along, when reporting that a special subscription has been
added, eliminating the asynchronous race condition in the first place, rather
than working around it.

[Wladimir Palant, 2017-03-29 14:45:59]

On 2017/03/29 14:29:27, Sebastian Noack wrote:
> I see. Perhaps we should rather change the message responder then, in order to
> send the filters along, when reporting that a special subscription has been
> added, eliminating the asynchronous race condition in the first place, rather
> than working around it.

That's what I suggested as well, we shouldn't break up the state like this.