Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29388555: Issue 5014 - Fix "Hide targeted messages?" notification (Closed)

Created:
March 19, 2017, 6:27 a.m. by kzar
Modified:
March 19, 2017, 10:06 a.m.
CC:
Sebastian Noack, wspee
Visibility:
Public.

Description

Issue 5014 - Fix "Hide targeted messages?" notification

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M lib/antiadblockInit.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
kzar
Patch Set 1 I am not familiar with this code, but I have tested this ...
March 19, 2017, 6:31 a.m. (2017-03-19 06:31:09 UTC) #1
Wladimir Palant
March 19, 2017, 9:42 a.m. (2017-03-19 09:42:14 UTC) #2
This doesn't seem to be necessary. We can rather change the import logic in
adblockpluschrome so that the string's name isn't adjusted:

 adblockplus/chrome/locale/*/global.properties =  subscription_invalid_location
   remove_subscription_warning
-  notification_antiadblock_title
-  notification_antiadblock_message
+  =notification_antiadblock_title
+  =notification_antiadblock_message

Powered by Google App Engine
This is Rietveld