Issue 29388605: Issue 5014 - Backport "Hide targeted messages?" fix for 144b2198215e

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29388605: Issue 5014 - Backport "Hide targeted messages?" fix for 144b2198215e (Closed)

Created:
March 19, 2017, 7 a.m. by kzar

Modified:
March 19, 2017, 10:06 a.m.

Reviewers:
Thomas Greiner

CC:
wspee, Wladimir Palant, Sebastian Noack

Visibility:
Public.

Description

Issue 5014 - Backport "Hide targeted messages?" fix for 144b2198215e Backported fix based upon 144b2198215e since we might need to do a second adblockpluschrome emergency release for this and we don't want to include the ESLint changes there. See the review for the changes for master: https://codereview.adblockplus.org/29388555/

Patch Set 1 #

Created: March 19, 2017, 7 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/antiadblockInit.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

kzar

March 19, 2017, 7:04 a.m. (2017-03-19 07:04:04 UTC) #1

Patch Set 1

Only tested with adblockpluschrome since this is not intended to be used for
adblockplus. For the proper changes which will be used (and I've tested) for
both see the link in the description.

Expand All Messages | Collapse All Messages