Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29390668: Noissue - Don't allow to have an empty event callback in JsEngine (Closed)

Created:
March 21, 2017, 2:27 p.m. by sergei
Modified:
March 24, 2017, 1:59 p.m.
Reviewers:
Eric, Oleksandr, hub
CC:
Felix Dahlke
Visibility:
Public.

Description

review: https://codereview.adblockplus.org/29390668 # This change originates from https://codereview.adblockplus.org/29389576/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/JsEngine.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
sergei
March 21, 2017, 2:52 p.m. (2017-03-21 14:52:47 UTC) #1
Oleksandr
Thanks :) Although I would still check if callback is null before calling it in ...
March 21, 2017, 4:25 p.m. (2017-03-21 16:25:51 UTC) #2
hub
March 21, 2017, 4:59 p.m. (2017-03-21 16:59:26 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld