Issue 4948 - add possibility to not send data depending on connection properties

Issue 4948 - add possibility to not send data depending on connection properties

This is update to libadblockplus-binaries repo

[sergei, 2017-03-22 08:41:36]

LGTM, though I think that it should be either another issue or noissue.

[anton, 2017-03-22 09:55:26]

On 2017/03/22 08:41:36, sergei wrote:
> LGTM, though I think that it should be either another issue or noissue.

Yes, i agree most commit message in
https://hg.adblockplus.org/libadblockplus-binaries/ are just like "Update to
..." but in my case it blocks the task.
I will use commit message like "updated to ...".

[sergei, 2017-03-22 10:05:26]

On 2017/03/22 09:55:26, anton wrote:
> On 2017/03/22 08:41:36, sergei wrote:
> > LGTM, though I think that it should be either another issue or noissue.
> 
> Yes, i agree most commit message in
> https://hg.adblockplus.org/libadblockplus-binaries/ are just like "Update to
> ..." but in my case it blocks the task.
> I will use commit message like "updated to ...".

Actually libadblockplus-binaries should not be aware about
libadblockplus-android because binaries is the dependency for android project
and the same binaries can be a dependency for any other project, so I'm not sure
that issue for libadblockplus-android should be in the title of commit message
for binaries.

Usually we create an issue to update to a particular revision with the list of
new features/fixes/etc, e.g. https://issues.adblockplus.org/ticket/4444. And I
think that the best way is to create such update issue and mark it as blocking
for #4948. However it's fine for me to have it as a noissue commit but put the
information about #4948 into the body of commit message.

[anton, 2017-03-22 10:07:49]

On 2017/03/22 10:05:26, sergei wrote:
> On 2017/03/22 09:55:26, anton wrote:
> > On 2017/03/22 08:41:36, sergei wrote:
> > > LGTM, though I think that it should be either another issue or noissue.
> > 
> > Yes, i agree most commit message in
> > https://hg.adblockplus.org/libadblockplus-binaries/ are just like "Update to
> > ..." but in my case it blocks the task.
> > I will use commit message like "updated to ...".
> 
> Actually libadblockplus-binaries should not be aware about
> libadblockplus-android because binaries is the dependency for android project
> and the same binaries can be a dependency for any other project, so I'm not
sure
> that issue for libadblockplus-android should be in the title of commit message
> for binaries.
> 
> Usually we create an issue to update to a particular revision with the list of
> new features/fixes/etc, e.g. https://issues.adblockplus.org/ticket/4444. And I
> think that the best way is to create such update issue and mark it as blocking
> for #4948. However it's fine for me to have it as a noissue commit but put the
> information about #4948 into the body of commit message.

I will just use "Updated to libadblockplus revision ec8e2edc66af" for commit
message.
Let me know if you prefer another commit message.

[Felix Dahlke, 2017-03-27 14:39:03]

LGTM - yeah let's not reference the issue in the commit messages, we never do
that in libadblockplus-android.

Moved Diego to CC since two reviewers to what is ultimately just a bunch of
binary updates and copied headers should be plenty.