pages/development-builds.html - Issue 29391741: Noissue - Added Microsoft Edge to devbuilds page

Delta Between Two Patch Sets: pages/development-builds.html

Issue 29391741: Noissue - Added Microsoft Edge to devbuilds page (Closed)

Left Patch Set: Created March 22, 2017, 1:26 p.m.

Right Patch Set: Removed language part from URL Created March 24, 2017, 10:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=Development builds	1 title=Development builds

2	2

3 <head>	3 <head>

4 <link href="https://chrome.google.com/webstore/detail/ldcecbkkoecffmfljeihcmifjj doepkn" rel="chrome-webstore-item">	4 <link href="https://chrome.google.com/webstore/detail/ldcecbkkoecffmfljeihcmifjj doepkn" rel="chrome-webstore-item">

5 <script>	5 <script>

6 document.addEventListener("DOMContentLoaded", function()	6 document.addEventListener("DOMContentLoaded", function()

7 {	7 {

8 var link = document.getElementById("chrome-install-link");	8 var link = document.getElementById("chrome-install-link");

9 if (typeof chrome != "undefined" && chrome.webstore)	9 if (typeof chrome != "undefined" && chrome.webstore)

10 {	10 {

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 <a href="https://chrome.google.com/webstore/detail/adblock-plus-development/ ldcecbkkoecffmfljeihcmifjjdoepkn" id="chrome-install-link">{{abp-for-chrome <fix >Adblock Plus</fix> for <fix>Chrome</fix> and <fix>Opera</fix>}}</a>	48 <a href="https://chrome.google.com/webstore/detail/adblock-plus-development/ ldcecbkkoecffmfljeihcmifjjdoepkn" id="chrome-install-link">{{abp-for-chrome <fix >Adblock Plus</fix> for <fix>Chrome</fix> and <fix>Opera</fix>}}</a>

49 <small>{{s11 (<a href="/devbuilds/adblockpluschrome/00latest.changelog.xhtml ">changelog</a>,	49 <small>{{s11 (<a href="/devbuilds/adblockpluschrome/00latest.changelog.xhtml ">changelog</a>,

50 <a href="/devbuilds/adblockpluschrome/">older builds</a>)}}</small>	50 <a href="/devbuilds/adblockpluschrome/">older builds</a>)}}</small>

51 </li>	51 </li>

52 <li>	52 <li>

53 <a href="/devbuilds/adblockplussafari/00latest.safariextz">{{s15 <fix>Adbloc k Plus</fix> for <fix>Safari</fix> (Safari 6 or above required)}}</a>	53 <a href="/devbuilds/adblockplussafari/00latest.safariextz">{{s15 <fix>Adbloc k Plus</fix> for <fix>Safari</fix> (Safari 6 or above required)}}</a>

54 <small>{{s16 (<a href="/devbuilds/adblockplussafari/00latest.changelog.xhtml ">changelog</a>,	54 <small>{{s16 (<a href="/devbuilds/adblockplussafari/00latest.changelog.xhtml ">changelog</a>,

55 <a href="/devbuilds/adblockplussafari/">older builds</a>)}}</small>	55 <a href="/devbuilds/adblockplussafari/">older builds</a>)}}</small>

56 </li>	56 </li>

57 <li>	57 <li>

58 <a href="https://www.microsoft.com/en-us/store/p/adblock-plus-development-bu ild/9nblggh4x3bm">{{abp-edge <fix>Adblock Plus</fix> for <fix>Microsoft Edge</fi x>}}</a>	58 <a href="https://www.microsoft.com/store/p/adblock-plus-development-build/9n blggh4x3bm">{{abp-edge <fix>Adblock Plus</fix> for <fix>Microsoft Edge</fix>}}</ a>
saroyanm 2017/03/24 10:17:30 Detail: I think we shouldn't use language specific Detail: I think we shouldn't use language specific version of the page: https://www.microsoft.com/store/p/adblock-plus-development-build/9nblggh4x3bm Sebastian Noack 2017/03/24 10:32:20 Well spotted. The language part can apparently be Show quoted text On 2017/03/24 10:17:30, saroyanm wrote: > Detail: I think we shouldn't use language specific version of the page: > > https://www.microsoft.com/store/p/adblock-plus-development-build/9nblggh4x3bm Well spotted. The language part can apparently be omitted. Done.
59 <small>{{changelog (<a href="/devbuilds/adblockplusedge/00latest.changelog.x html">changelog</a>)}}</small>	59 <small>{{changelog (<a href="/devbuilds/adblockplusedge/00latest.changelog.x html">changelog</a>)}}</small>
saroyanm 2017/03/24 10:17:30 Is it intentional that the link is translatable ? Is it intentional that the link is translatable ? Sebastian Noack 2017/03/24 10:32:20 This seems to be consistent with the rest of this Show quoted text On 2017/03/24 10:17:30, saroyanm wrote: > Is it intentional that the link is translatable ? This seems to be consistent with the rest of this page. The link itself doesn't need to be translated. But note that the a-tag's attributes are stripped anyway in the translation files, so effectively we just translate "(<a>changelog</a>)" here, which seems to be correct as some languages might not use parentheses. Ideally the product name would be in the same string (in order to target RTL languages), but again the way I did it here is consistent. saroyanm 2017/03/24 11:01:30 Good point. Show quoted text On 2017/03/24 10:32:20, Sebastian Noack wrote: > On 2017/03/24 10:17:30, saroyanm wrote: > > Is it intentional that the link is translatable ? > > This seems to be consistent with the rest of this page. The link itself doesn't > need to be translated. But note that the a-tag's attributes are stripped anyway > in the translation files, so effectively we just translate "(<a>changelog</a>)" > here, which seems to be correct as some languages might not use parentheses. > Ideally the product name would be in the same string (in order to target RTL > languages), but again the way I did it here is consistent. Good point.
60 </li>	60 </li>

61 <li>	61 <li>

62 <a href="/devbuilds/adblockplusie/00latest.exe">{{s17 <fix>Adblock Plus</fix > for <fix>Internet Explorer</fix> (Internet Explorer 8 or above required)}}</a>	62 <a href="/devbuilds/adblockplusie/00latest.exe">{{s17 <fix>Adblock Plus</fix > for <fix>Internet Explorer</fix> (Internet Explorer 8 or above required)}}</a>

63 <small>{{s18 (<a href="/devbuilds/adblockplusie/">older builds</a>)}}</small >	63 <small>{{s18 (<a href="/devbuilds/adblockplusie/">older builds</a>)}}</small >

64 </li>	64 </li>

65 <li>	65 <li>

66 <a href="/devbuilds/adblockplusandroid/00latest.apk">{{s19 <fix>Adblock Plus </fix> for <fix>Android</fix>}}</a>	66 <a href="/devbuilds/adblockplusandroid/00latest.apk">{{s19 <fix>Adblock Plus </fix> for <fix>Android</fix>}}</a>

67 <small>{{s20 (<a href="/devbuilds/adblockplusandroid/00latest.changelog.xhtm l">changelog</a>,	67 <small>{{s20 (<a href="/devbuilds/adblockplusandroid/00latest.changelog.xhtm l">changelog</a>,

68 <a href="/devbuilds/adblockplusandroid/">older builds</a>).}}</small>	68 <a href="/devbuilds/adblockplusandroid/">older builds</a>).}}</small>

69 </li>	69 </li>

(...skipping 26 matching lines...) Expand all Loading...
96 stable release.}}	96 stable release.}}

97 </p>	97 </p>

98	98

99 <p id="opera-install">	99 <p id="opera-install">

100 {{s31 <strong>Important Opera installation notice</strong>: Opera adds extensi ons not downloaded via the webstore but deactivates them by default. After addin g the ABP development build, go to the extensions menu and enable it.}}	100 {{s31 <strong>Important Opera installation notice</strong>: Opera adds extensi ons not downloaded via the webstore but deactivates them by default. After addin g the ABP development build, go to the extensions menu and enable it.}}

101 </p>	101 </p>

102	102

103 <h2 id="changes">{{s32 How do I know what has changed?}}</h2>	103 <h2 id="changes">{{s32 How do I know what has changed?}}</h2>

104	104

105 <p>{{s33 When the browser shows you the notification about available updates, cl ick the development build and then "Show Information" button. This will display the list of all changes in this build. For a more high-level overview of the cha nges and additional information please follow the <a href="/development-builds/" >development build announcements</a>. You can subscribe to the <a href="/rss/?se ction=development-builds">RSS feed</a> in your favorite feed reader.}}</p>	105 <p>{{s33 When the browser shows you the notification about available updates, cl ick the development build and then "Show Information" button. This will display the list of all changes in this build. For a more high-level overview of the cha nges and additional information please follow the <a href="/development-builds/" >development build announcements</a>. You can subscribe to the <a href="/rss/?se ction=development-builds">RSS feed</a> in your favorite feed reader.}}</p>

LEFT	RIGHT