Noissue - Added Microsoft Edge to devbuilds page

Noissue - Added Microsoft Edge to devbuilds page

[saroyanm, 2017-03-24 10:17:30]

Just 2 small notes.

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
File pages/development-builds.html (right):

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
pages/development-builds.html:58: <a
href="https://www.microsoft.com/en-us/store/p/adblock-plus-development-build/9nblggh4x3bm">{{abp-edge
<fix>Adblock Plus</fix> for <fix>Microsoft Edge</fix>}}</a>
Detail: I think we shouldn't use language specific version of the page:

https://www.microsoft.com/store/p/adblock-plus-development-build/9nblggh4x3bm

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
pages/development-builds.html:59: <small>{{changelog (<a
href="/devbuilds/adblockplusedge/00latest.changelog.xhtml">changelog</a>)}}</small>
Is it intentional that the link is translatable ?

[Sebastian Noack, 2017-03-24 10:32:20]

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
File pages/development-builds.html (right):

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
pages/development-builds.html:58: <a
href="https://www.microsoft.com/en-us/store/p/adblock-plus-development-build/9nblggh4x3bm">{{abp-edge
<fix>Adblock Plus</fix> for <fix>Microsoft Edge</fix>}}</a>
On 2017/03/24 10:17:30, saroyanm wrote:
> Detail: I think we shouldn't use language specific version of the page:
> 
> https://www.microsoft.com/store/p/adblock-plus-development-build/9nblggh4x3bm

Well spotted. The language part can apparently be omitted. Done.

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
pages/development-builds.html:59: <small>{{changelog (<a
href="/devbuilds/adblockplusedge/00latest.changelog.xhtml">changelog</a>)}}</small>
On 2017/03/24 10:17:30, saroyanm wrote:
> Is it intentional that the link is translatable ?

This seems to be consistent with the rest of this page. The link itself doesn't
need to be translated. But note that the a-tag's attributes are stripped anyway
in the translation files, so effectively we just translate "(<a>changelog</a>)"
here, which seems to be correct as some languages might not use parentheses.
Ideally the product name would be in the same string (in order to target RTL
languages), but again the way I did it here is consistent.

[saroyanm, 2017-03-24 11:01:30]

LGTM

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
File pages/development-builds.html (right):

https://codereview.adblockplus.org/29391741/diff/29391744/pages/development-b...
pages/development-builds.html:59: <small>{{changelog (<a
href="/devbuilds/adblockplusedge/00latest.changelog.xhtml">changelog</a>)}}</small>
On 2017/03/24 10:32:20, Sebastian Noack wrote:
> On 2017/03/24 10:17:30, saroyanm wrote:
> > Is it intentional that the link is translatable ?
> 
> This seems to be consistent with the rest of this page. The link itself
doesn't
> need to be translated. But note that the a-tag's attributes are stripped
anyway
> in the translation files, so effectively we just translate
"(<a>changelog</a>)"
> here, which seems to be correct as some languages might not use parentheses.
> Ideally the product name would be in the same string (in order to target RTL
> languages), but again the way I did it here is consistent.

Good point.