Unified Diff: test/Notification.cpp
Issue 29391770:
Noissue - Fix sign comparison warnings in tests. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created March 22, 2017, 3:32 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
test/ReferrerMapping.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/Notification.cpp |
| =================================================================== |
| --- a/test/Notification.cpp |
| +++ b/test/Notification.cpp |
| @@ -193,21 +193,21 @@ TEST_F(NotificationTest, MarkAsShown) |
| EXPECT_FALSE(PeekNotification()); |
| } |
| TEST_F(NotificationTest, NoLinks) |
| { |
| AddNotification("{ id: 'id'}"); |
| NotificationPtr notification = PeekNotification(); |
| ASSERT_TRUE(notification); |
| - EXPECT_EQ(0, notification->GetLinks().size()); |
| + EXPECT_EQ(0u, notification->GetLinks().size()); |
| } |
| TEST_F(NotificationTest, Links) |
| { |
| AddNotification("{ id: 'id', links: ['link1', 'link2'] }"); |
| NotificationPtr notification = PeekNotification(); |
| ASSERT_TRUE(notification); |
| std::vector<std::string> notificationLinks = notification->GetLinks(); |
| - ASSERT_EQ(2, notificationLinks.size()); |
| + ASSERT_EQ(2u, notificationLinks.size()); |
| EXPECT_EQ("link1", notificationLinks[0]); |
| EXPECT_EQ("link2", notificationLinks[1]); |
| } |
« no previous file with comments
|
« no previous file
|
test/ReferrerMapping.cpp » ('j')
|
no next file with comments »
