Issue 5031 - Avoid double deletion of C++ objects

libadblockplus-android/jni/JniCallbacks.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 66 matching lines @@
   void Callback(const std::string& arg, const AdblockPlus::JsValuePtr jsValue);
 };
 
 class JniLogSystemCallback : public JniCallbackBase, public AdblockPlus::LogSystem
 {
 public:
   JniLogSystemCallback(JNIEnv* env, jobject callbackObject);
   void operator()(AdblockPlus::LogSystem::LogLevel logLevel, const std::string& message, const std::string& source);
 };
 
+/**
+ * Shared smart pointer to a `JniLogSystemCallback` instance.
+ */
+typedef std::shared_ptr<JniLogSystemCallback> JniLogSystemCallbackPtr;

[sergei, 2017/03/29 11:21:55]

BTW, it seems you are not working with JniCallbackBase* from Java, so I would
recommend to remove that typedef and use AdblockPlus::LogSystemPtr instead.

+
 class JniShowNotificationCallback : public JniCallbackBase
 {
 public:
   JniShowNotificationCallback(JNIEnv* env, jobject callbackObject);
   void Callback(const AdblockPlus::NotificationPtr&);
 };
 
 class JniWebRequest : public JniCallbackBase, public AdblockPlus::WebRequest
 {
 public:
   JniWebRequest(JNIEnv* env, jobject callbackObject);
   AdblockPlus::ServerResponse GET(const std::string& url, const AdblockPlus::HeaderList& requestHeaders) const;
 
 private:
   jobject NewTuple(JNIEnv* env, const std::string& a, const std::string& b) const;
 };
 
 #endif /* JNICALLBACKS_H */