Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29397600: Issue 5031 - Avoid double deletion of C++ objects (Closed)

Created:
March 29, 2017, 11:02 a.m. by anton
Modified:
March 30, 2017, 12:04 p.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5031 - Avoid double deletion of C++ objects

Patch Set 1 #

Total comments: 1

Patch Set 2 : sergei's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M libadblockplus-android/jni/JniLogSystem.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
anton
March 29, 2017, 11:04 a.m. (2017-03-29 11:04:15 UTC) #1
sergei
https://codereview.adblockplus.org/29397600/diff/29397601/libadblockplus-android/jni/JniCallbacks.h File libadblockplus-android/jni/JniCallbacks.h (right): https://codereview.adblockplus.org/29397600/diff/29397601/libadblockplus-android/jni/JniCallbacks.h#newcode90 libadblockplus-android/jni/JniCallbacks.h:90: typedef std::shared_ptr<JniLogSystemCallback> JniLogSystemCallbackPtr; BTW, it seems you are not ...
March 29, 2017, 11:21 a.m. (2017-03-29 11:21:55 UTC) #2
sergei
LGTM
March 29, 2017, 2:08 p.m. (2017-03-29 14:08:31 UTC) #3
diegocarloslima
March 30, 2017, 11:58 a.m. (2017-03-30 11:58:08 UTC) #4
On 2017/03/29 14:08:31, sergei wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld