libadblockplus-android/jni/JniCallbacks.h - Issue 29397600: Issue 5031 - Avoid double deletion of C++ objects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniCallbacks.h

Issue 29397600: Issue 5031 - Avoid double deletion of C++ objects (Closed)

Patch Set: Created March 29, 2017, 11:02 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniCallbacks.h

diff --git a/libadblockplus-android/jni/JniCallbacks.h b/libadblockplus-android/jni/JniCallbacks.h

index 4a112fdfdccf773a45a6d99ce92bc17740a47ddd..4566f5cff747ee0c14a8db9dc6ffb1abdeec3e4c 100644

--- a/libadblockplus-android/jni/JniCallbacks.h

+++ b/libadblockplus-android/jni/JniCallbacks.h

@@ -84,6 +84,11 @@ public:

void operator()(AdblockPlus::LogSystem::LogLevel logLevel, const std::string& message, const std::string& source);

};

+/**

+ * Shared smart pointer to a `JniLogSystemCallback` instance.

+ */

+typedef std::shared_ptr<JniLogSystemCallback> JniLogSystemCallbackPtr;

sergei 2017/03/29 11:21:55 BTW, it seems you are not working with JniCallback

class JniShowNotificationCallback : public JniCallbackBase

{

public:

« no previous file with comments | « no previous file | libadblockplus-android/jni/JniLogSystem.cpp » ('j') | no next file with comments »