Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

Issue 29397615: Issue 5053 - Release JsValues explicitly (Closed)
Patch Set: Created March 29, 2017, 12:12 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
diff --git a/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java b/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
index cac1ec3163b97f07a5ab7faa7614e3b8740f1d82..0b434f89ff10e3e8538ae1edcdecc54f4869c0be 100644
--- a/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
+++ b/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
@@ -990,12 +990,22 @@ public class AdblockWebView extends WebView
};
List<Subscription> subscriptions = adblockEngine.getFilterEngine().getListedSubscriptions();
- d("Listed subscriptions: " + subscriptions.size());
- if (debugMode)
+ try
+ {
+ d("Listed subscriptions: " + subscriptions.size());
+ if (debugMode)
diegocarloslima 2017/03/30 14:19:29 Isn't this check redundant here, since d() already
anton 2017/03/30 14:34:15 Acknowledged. Bu it's scope of scope of this task/
+ {
+ for (Subscription eachSubscription : subscriptions)
+ {
+ d("Subscribed to " + eachSubscription);
+ }
+ }
+ }
+ finally
{
for (Subscription eachSubscription : subscriptions)
{
- d("Subscribed to " + eachSubscription);
+ eachSubscription.dispose();
}
}

Powered by Google App Engine
This is Rietveld