Issue 5055 - Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaab…

lib/child/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 74 matching lines @@
               // Invalid URL?
             }
 
             for (let filter of filters)
             {
               RequestNotifier.addNodeData(subject.document, subject.top, {
                 contentType: "ELEMHIDE",
                 docDomain: docDomain,
                 thirdParty: false,
                 // TODO: Show the actual matching selector here?
                 location: filter.replace(/^.*?##/, ""),

[Sebastian Noack, 2017/03/29 12:58:41]

Another change caused the second argument to addSelectorFunc() no longer being a
distinct list of filters in arbitrary order, but a list of filters (with
potential duplicates), where each item corresponds to the selector at the same
position in the array given as first argument:
https://issues.adblockplus.org/ticket/4825

Does that require any changes here?

[Wladimir Palant, 2017/03/29 13:28:52]

It doesn't strictly require changes but we can indeed solve this TODO comment
now, showing the effective selector in the list of blockable items. Note that
the code here has a bug in the first place - we shouldn't be removing ##, we
leave it for element hiding filters to make it obvious what this pseudo-location
is about.

                 filter: filter,
                 filterType: "elemhideemulation"
               });
             }
           }
         );
 
-        handler.load(() => handler.apply());
+        handler.apply();

[Sebastian Noack, 2017/03/29 12:58:41]

Note that this change is redundant with
https://issues.adblockplus.org/ticket/4928
Feel free to either land that issue first, or close it as a duplicate.

[Wladimir Palant, 2017/03/29 13:28:52]

I've resolved it as a duplicate since that change needs to be done as part of a
dependency update anyway.

       };
 
       subject.addEventListener("load", onReady);
     };
 
     Services.obs.addObserver(onContentWindow, "content-document-global-created",
         false);
     onShutdown.add(() =>
     {
       Services.obs.removeObserver(onContentWindow,
           "content-document-global-created");
     });
   }
 
   initElemHideEmulation();
 })();