Issue 5055 - Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaab…

Issue 5055 - Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaabb9c639

[Sebastian Noack, 2017-03-29 12:58:41]

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
File lib/child/elemHideEmulation.js (left):

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
lib/child/elemHideEmulation.js:95: location: filter.replace(/^.*?##/, ""),
Another change caused the second argument to addSelectorFunc() no longer being a
distinct list of filters in arbitrary order, but a list of filters (with
potential duplicates), where each item corresponds to the selector at the same
position in the array given as first argument:
https://issues.adblockplus.org/ticket/4825

Does that require any changes here?

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
File lib/child/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
lib/child/elemHideEmulation.js:103: handler.apply();
Note that this change is redundant with
https://issues.adblockplus.org/ticket/4928
Feel free to either land that issue first, or close it as a duplicate.

[Wladimir Palant, 2017-03-29 13:28:53]

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
File lib/child/elemHideEmulation.js (left):

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
lib/child/elemHideEmulation.js:95: location: filter.replace(/^.*?##/, ""),
On 2017/03/29 12:58:41, Sebastian Noack wrote:
> Another change caused the second argument to addSelectorFunc() no longer being
a
> distinct list of filters in arbitrary order, but a list of filters (with
> potential duplicates), where each item corresponds to the selector at the same
> position in the array given as first argument:
> https://issues.adblockplus.org/ticket/4825
> 
> Does that require any changes here?

It doesn't strictly require changes but we can indeed solve this TODO comment
now, showing the effective selector in the list of blockable items. Note that
the code here has a bug in the first place - we shouldn't be removing ##, we
leave it for element hiding filters to make it obvious what this pseudo-location
is about.

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
File lib/child/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29397620/diff/29397621/lib/child/elemHideE...
lib/child/elemHideEmulation.js:103: handler.apply();
On 2017/03/29 12:58:41, Sebastian Noack wrote:
> Note that this change is redundant with
> https://issues.adblockplus.org/ticket/4928
> Feel free to either land that issue first, or close it as a duplicate.

I've resolved it as a duplicate since that change needs to be done as part of a
dependency update anyway.

[Sebastian Noack, 2017-03-29 13:34:16]

LGTM