Issue 29397638: Issue 5057 - Update adblockpluscore dependency to revision 3bdddf0e8343

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29397638: Issue 5057 - Update adblockpluscore dependency to revision 3bdddf0e8343 (Closed)

Created:
March 29, 2017, 2:21 p.m. by Wladimir Palant

Modified:
March 30, 2017, 10:13 a.m.

Reviewers:
kzar

Base URL:
https://hg.adblockplus.org/adblockplus

Visibility:
Public.

Description

Issue 5057 - Update adblockpluscore dependency to revision 3bdddf0e8343

Patch Set 1 #

Total comments: 4

Created: March 29, 2017, 2:21 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
	M	chrome/content/ui/filters-backup.js	View		1 chunk	+14 lines, -12 lines	4 comments	Download
	M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kzar

Again not too familiar with the code but it LGTM. Luckily only your adblockpluscore changes ...

March 30, 2017, 5:45 a.m. (2017-03-30 05:45:51 UTC) #2

Wladimir Palant

March 30, 2017, 10:13 a.m. (2017-03-30 10:13:12 UTC) #3

https://codereview.adblockplus.org/29397638/diff/29397639/chrome/content/ui/f...
File chrome/content/ui/filters-backup.js (right):

https://codereview.adblockplus.org/29397638/diff/29397639/chrome/content/ui/f...
chrome/content/ui/filters-backup.js:109: item.addEventListener("command",
function()
On 2017/03/30 05:45:51, kzar wrote:
> Nit: Any reason not to use an arrow function here?

I'd rather not make unnecessary changes to this code.

https://codereview.adblockplus.org/29397638/diff/29397639/chrome/content/ui/f...
chrome/content/ui/filters-backup.js:113:
this.restoreInsertionPoint.parentNode.insertBefore(item,
this.restoreInsertionPoint.nextSibling);
On 2017/03/30 05:45:51, kzar wrote:
> Nit: Long line.

Same here, I'd rather not make unnecessary changes to this code.

Expand All Messages | Collapse All Messages