Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29397642: Noissue - update to libadblockplus revision b59b88dcad1a (Closed)

Created:
March 29, 2017, 4:16 p.m. by anton
Modified:
March 30, 2017, 1:52 p.m.
Reviewers:
sergei, Felix Dahlke
CC:
diegocarloslima, René Jeschke
Visibility:
Public.

Description

Noissue - update to libadblockplus revision b59b88dcad1a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M android_armeabi-v7a/libadblockplus.a View Binary file 0 comments Download
M android_armeabi-v7a/libv8_base.a View Binary file 0 comments Download
M android_armeabi-v7a/libv8_snapshot.a View Binary file 0 comments Download
M android_x86/libadblockplus.a View Binary file 0 comments Download
M android_x86/libv8_base.a View Binary file 0 comments Download
M android_x86/libv8_snapshot.a View Binary file 0 comments Download
A + include/AdblockPlus/ITimer.h View 1 chunk +16 lines, -20 lines 1 comment Download
M include/AdblockPlus/JsEngine.h View 6 chunks +26 lines, -16 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4
anton
March 29, 2017, 4:17 p.m. (2017-03-29 16:17:21 UTC) #1
sergei
Basically, changes in headers are here and one does not review these binaries on practice. ...
March 29, 2017, 4:28 p.m. (2017-03-29 16:28:28 UTC) #2
anton
https://codereview.adblockplus.org/29397642/diff/29397643/include/AdblockPlus/ITimer.h File include/AdblockPlus/ITimer.h (right): https://codereview.adblockplus.org/29397642/diff/29397643/include/AdblockPlus/ITimer.h#newcode30 include/AdblockPlus/ITimer.h:30: struct ITimer This is obviously git/rietveld bug as the ...
March 30, 2017, 5:27 a.m. (2017-03-30 05:27:30 UTC) #3
Felix Dahlke
March 30, 2017, 1:16 p.m. (2017-03-30 13:16:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld