Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by Wladimir Palant
Modified:
2 years, 10 months ago
Reviewers:
sergei
CC:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

The impact on code size was less than I hoped for but this still makes the code cleaner and more performant.

Patch Set 1 #

Patch Set 2 : Added missing files #

Patch Set 3 : Rebased and made the code deal with 64-bit properties #

Patch Set 4 : Rebased #

Patch Set 5 : Removed newValue and oldValue parameters #

Total comments: 4

Patch Set 6 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -78 lines) Patch
A compiled/FilterNotifier.h View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
A compiled/FilterNotifier.cpp View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
M compiled/String.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M compiled/bindings.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M compiled/bindings.ipp View 1 2 3 2 chunks +21 lines, -12 lines 0 comments Download
M compiled/filter/ActiveFilter.h View 1 2 3 4 2 chunks +11 lines, -10 lines 0 comments Download
M compiled/shell.js View 1 chunk +0 lines, -2 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.h View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M compiled/subscription/Subscription.h View 1 2 3 4 2 chunks +17 lines, -42 lines 0 comments Download
M test/filterClasses.js View 1 2 3 4 2 chunks +60 lines, -0 lines 0 comments Download
M test/subscriptionClasses.js View 1 2 3 4 5 2 chunks +109 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Wladimir Palant
2 years, 11 months ago (2017-03-30 10:08:25 UTC) #1
Wladimir Palant
Added Hubert to CC.
2 years, 11 months ago (2017-03-30 17:41:09 UTC) #2
Wladimir Palant
I somehow forgot to add new files here. Patch set 2 fixes that.
2 years, 10 months ago (2017-04-06 08:09:00 UTC) #3
Wladimir Palant
Patch set 3 has been rebased. Due to changes to subscription classes it now accepts ...
2 years, 10 months ago (2017-04-07 07:18:00 UTC) #4
Wladimir Palant
In Patch set 5 I simplified this considerably by removing newValue and oldValue parameters altogether ...
2 years, 10 months ago (2017-04-15 15:07:24 UTC) #5
sergei
https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNotifier.cpp File compiled/FilterNotifier.cpp (right): https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNotifier.cpp#newcode24 compiled/FilterNotifier.cpp:24: void FilterChange(Topic topic, Filter* filter) It's not important here, ...
2 years, 10 months ago (2017-04-19 12:18:03 UTC) #6
Wladimir Palant
Addressed Sergei's comments in Patch set 6. https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNotifier.cpp File compiled/FilterNotifier.cpp (right): https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNotifier.cpp#newcode24 compiled/FilterNotifier.cpp:24: void FilterChange(Topic ...
2 years, 10 months ago (2017-04-20 08:03:14 UTC) #7
sergei
2 years, 10 months ago (2017-04-20 08:11:20 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5