Issue 5063 - [emscripten] Make FilterNotifier calls more efficient

The impact on code size was less than I hoped for but this still makes the code cleaner and more performant.

[Wladimir Palant, 2017-03-30 17:41:09]

Added Hubert to CC.

[Wladimir Palant, 2017-04-06 08:09:00]

I somehow forgot to add new files here. Patch set 2 fixes that.

[Wladimir Palant, 2017-04-07 07:18:00]

Patch set 3 has been rebased. Due to changes to subscription classes it now
accepts with uint64_t instead of double.

[Wladimir Palant, 2017-04-15 15:07:24]

In Patch set 5 I simplified this considerably by removing newValue and oldValue
parameters altogether - the existing use doesn't justify keeping this
functionality around.

[sergei, 2017-04-19 12:18:03]

https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNoti...
File compiled/FilterNotifier.cpp (right):

https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNoti...
compiled/FilterNotifier.cpp:24: void FilterChange(Topic topic, Filter* filter)
It's not important here, but I saw it in some other codereviews. To avoid
undesired indentation of function bodies one can use
void FilterNotifier::FilterChange(...
in cpp file and the function will be correctly found by linker.

https://codereview.adblockplus.org/29398669/diff/29413563/test/subscriptionCl...
File test/subscriptionClasses.js (right):

https://codereview.adblockplus.org/29398669/diff/29413563/test/subscriptionCl...
test/subscriptionClasses.js:269: let listener = (topic, subscription, newValue,
oldValue) =>
newValue and oldValue arguments are not used anymore.

[Wladimir Palant, 2017-04-20 08:03:14]

Addressed Sergei's comments in Patch set 6.

https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNoti...
File compiled/FilterNotifier.cpp (right):

https://codereview.adblockplus.org/29398669/diff/29413563/compiled/FilterNoti...
compiled/FilterNotifier.cpp:24: void FilterChange(Topic topic, Filter* filter)
On 2017/04/19 12:18:03, sergei wrote:
> It's not important here, but I saw it in some other codereviews. To avoid
> undesired indentation of function bodies one can use
> void FilterNotifier::FilterChange(...
> in cpp file and the function will be correctly found by linker.

Done.

https://codereview.adblockplus.org/29398669/diff/29413563/test/subscriptionCl...
File test/subscriptionClasses.js (right):

https://codereview.adblockplus.org/29398669/diff/29413563/test/subscriptionCl...
test/subscriptionClasses.js:269: let listener = (topic, subscription, newValue,
oldValue) =>
On 2017/04/19 12:18:03, sergei wrote:
> newValue and oldValue arguments are not used anymore.

Done.

[sergei, 2017-04-20 08:11:20]

LGTM