compiled/subscription/DownloadableSubscription.h - Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/subscription/DownloadableSubscription.h

Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Left Patch Set: Created March 30, 2017, 10:08 a.m.

Right Patch Set: Addressed comments Created April 20, 2017, 8 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 10 matching lines...) Expand all Loading...
21	21

22 class DownloadableSubscription : public Subscription	22 class DownloadableSubscription : public Subscription

23 {	23 {

24 public:	24 public:

25 explicit DownloadableSubscription(const String& id);	25 explicit DownloadableSubscription(const String& id);

26	26

27 SUBSCRIPTION_PROPERTY(bool, mFixedTitle, SUBSCRIPTION_FIXEDTITLE,	27 SUBSCRIPTION_PROPERTY(bool, mFixedTitle, SUBSCRIPTION_FIXEDTITLE,

28 GetFixedTitle, SetFixedTitle);	28 GetFixedTitle, SetFixedTitle);

29 SUBSCRIPTION_STRING_PROPERTY(mHomepage, SUBSCRIPTION_HOMEPAGE,	29 SUBSCRIPTION_STRING_PROPERTY(mHomepage, SUBSCRIPTION_HOMEPAGE,

30 GetHomepage, SetHomepage);	30 GetHomepage, SetHomepage);

31 SUBSCRIPTION_PROPERTY(double, mLastCheck, SUBSCRIPTION_LASTCHECK,	31 SUBSCRIPTION_PROPERTY(uint64_t, mLastCheck, SUBSCRIPTION_LASTCHECK,

32 GetLastCheck, SetLastCheck);	32 GetLastCheck, SetLastCheck);

33 SUBSCRIPTION_PROPERTY(double, mHardExpiration, NONE,	33 SUBSCRIPTION_PROPERTY(uint64_t, mHardExpiration, NONE,

34 GetHardExpiration, SetHardExpiration);	34 GetHardExpiration, SetHardExpiration);

35 SUBSCRIPTION_PROPERTY(double, mSoftExpiration, NONE,	35 SUBSCRIPTION_PROPERTY(uint64_t, mSoftExpiration, NONE,

36 GetSoftExpiration, SetSoftExpiration);	36 GetSoftExpiration, SetSoftExpiration);

37 SUBSCRIPTION_PROPERTY(double, mLastDownload, SUBSCRIPTION_LASTDOWNLOAD,	37 SUBSCRIPTION_PROPERTY(uint64_t, mLastDownload, SUBSCRIPTION_LASTDOWNLOAD,

38 GetLastDownload, SetLastDownload);	38 GetLastDownload, SetLastDownload);

39 SUBSCRIPTION_STRING_PROPERTY(mDownloadStatus, SUBSCRIPTION_DOWNLOADSTATUS,	39 SUBSCRIPTION_STRING_PROPERTY(mDownloadStatus, SUBSCRIPTION_DOWNLOADSTATUS,

40 GetDownloadStatus, SetDownloadStatus);	40 GetDownloadStatus, SetDownloadStatus);

41 SUBSCRIPTION_PROPERTY(double, mLastSuccess, NONE,	41 SUBSCRIPTION_PROPERTY(uint64_t, mLastSuccess, NONE,

42 GetLastSuccess, SetLastSuccess);	42 GetLastSuccess, SetLastSuccess);

43 SUBSCRIPTION_PROPERTY(int, mErrorCount, SUBSCRIPTION_ERRORS,	43 SUBSCRIPTION_PROPERTY(int, mErrorCount, SUBSCRIPTION_ERRORS,

44 GetErrorCount, SetErrorCount);	44 GetErrorCount, SetErrorCount);

45 SUBSCRIPTION_PROPERTY(double, mDataRevision, NONE,	45 SUBSCRIPTION_PROPERTY(uint64_t, mDataRevision, NONE,

46 GetDataRevision, SetDataRevision);	46 GetDataRevision, SetDataRevision);

47 SUBSCRIPTION_STRING_PROPERTY(mRequiredVersion, NONE,	47 SUBSCRIPTION_STRING_PROPERTY(mRequiredVersion, NONE,

48 GetRequiredVersion, SetRequiredVersion);	48 GetRequiredVersion, SetRequiredVersion);

49 SUBSCRIPTION_PROPERTY(int, mDownloadCount, NONE,	49 SUBSCRIPTION_PROPERTY(int, mDownloadCount, NONE,

50 GetDownloadCount, SetDownloadCount);	50 GetDownloadCount, SetDownloadCount);

51	51

52 EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;	52 EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;

53 };	53 };

LEFT	RIGHT