Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/FilterNotifier.cpp

Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Removed newValue and oldValue parameters Created April 15, 2017, 3:05 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/FilterNotifier.cpp
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/FilterNotifier.cpp
@@ -0,0 +1,39 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2017 eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <emscripten.h>
+
+#include "FilterNotifier.h"
+
+namespace FilterNotifier
+{
+ void FilterChange(Topic topic, Filter* filter)
sergei 2017/04/19 12:18:03 It's not important here, but I saw it in some othe
Wladimir Palant 2017/04/20 08:03:14 Done.
+ {
+ EM_ASM_ARGS({
+ FilterNotifier.triggerListeners(notifierTopics.get($0),
+ exports.Filter.fromPointer($1));
+ }, topic, filter);
+ }
+
+ void SubscriptionChange(Topic topic, Subscription* subscription)
+ {
+ EM_ASM_ARGS({
+ FilterNotifier.triggerListeners(notifierTopics.get($0),
+ exports.Subscription.fromPointer($1));
+ }, topic, subscription);
+ }
+}
« no previous file with comments | « compiled/FilterNotifier.h ('k') | compiled/String.h » ('j') | test/subscriptionClasses.js » ('J')

Powered by Google App Engine
This is Rietveld