Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29398811: Issue 5075 - JsEngine crashes in dtor with LogSystemPtr ref (Closed)

Created:
March 30, 2017, 10:27 p.m. by anton
Modified:
March 31, 2017, 7:29 a.m.
Visibility:
Public.

Description

Issue 5075 - JsEngine crashes in dtor with LogSystemPtr ref

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M libadblockplus-android/jni/JniJsEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
anton
March 30, 2017, 10:28 p.m. (2017-03-30 22:28:09 UTC) #1
sergei
LGTM
March 30, 2017, 10:28 p.m. (2017-03-30 22:28:34 UTC) #2
Felix Dahlke
LGTM
March 31, 2017, 7:16 a.m. (2017-03-31 07:16:36 UTC) #3
diegocarloslima
March 31, 2017, 7:29 a.m. (2017-03-31 07:29:23 UTC) #4
Message was sent while issue was closed.
On 2017/03/31 07:16:36, Felix Dahlke wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld