Issue 5077 - Update buildtools dependency to 1ed9c0c32f78

Issue 5077 - Update buildtools dependency to 1ed9c0c32f78

[kzar, 2017-03-31 06:02:54]

Patch Set 1

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies#newcode3
dependencies:3: buildtools = buildtools git:5060-modules
I will update this with the proper revision once #5060 lands.

[Sebastian Noack, 2017-04-03 06:07:25]

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies#newcode3
dependencies:3: buildtools = buildtools git:5060-modules
On 2017/03/31 06:02:54, kzar wrote:
> I will update this with the proper revision once #5060 lands.

This can be done now, #5060 has landed.

https://codereview.adblockplus.org/29399577/diff/29399578/metadata.common
File metadata.common (left):

https://codereview.adblockplus.org/29399577/diff/29399578/metadata.common#old...
metadata.common:17: common.js
You also have to add the injectinfomodule option for the bundles that are
expected to have the "info" module. Also don't forget to update the issue
description accordingly.

[kzar, 2017-04-03 06:21:59]

Patch Set 2 : Move injectinfomodule change into correct commit

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies#newcode3
dependencies:3: buildtools = buildtools git:5060-modules
On 2017/04/03 06:07:25, Sebastian Noack wrote:
> On 2017/03/31 06:02:54, kzar wrote:
> > I will update this with the proper revision once #5060 lands.
> 
> This can be done now, #5060 has landed.

No, it's also blocked by #5078. Before you ask why see my working branch
https://github.com/adblockplus/adblockpluschrome/compare/master...kzar:5080-c...

https://codereview.adblockplus.org/29399577/diff/29399578/metadata.common
File metadata.common (left):

https://codereview.adblockplus.org/29399577/diff/29399578/metadata.common#old...
metadata.common:17: common.js
On 2017/04/03 06:07:25, Sebastian Noack wrote:
> You also have to add the injectinfomodule option for the bundles that are
> expected to have the "info" module. Also don't forget to update the issue
> description accordingly.

Whoops you're right, I did that but put it in the wrong commit in my branch.
Done.

[kzar, 2017-04-03 07:36:27]

Patch Set 3 : Update revision

[Sebastian Noack, 2017-04-03 10:14:28]

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399577/diff/29399578/dependencies#newcode3
dependencies:3: buildtools = buildtools git:5060-modules
On 2017/04/03 06:21:59, kzar wrote:
> On 2017/04/03 06:07:25, Sebastian Noack wrote:
> > On 2017/03/31 06:02:54, kzar wrote:
> > > I will update this with the proper revision once #5060 lands.
> > 
> > This can be done now, #5060 has landed.
> 
> No, it's also blocked by #5078. Before you ask why see my working branch
>
https://github.com/adblockplus/adblockpluschrome/compare/master...kzar:5080-c...

For reference, #5078 got rejected in favor of using modules consistently. So
this comment is no longer relevant, and the dependency's revision got updated
accordingly. So LGTM.