Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java

Issue 29399749: Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parame… (Closed)
Patch Set: Created March 31, 2017, 1:28 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java
diff --git a/libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java b/libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java
index 9a97f3755a737d5bbbd6bbf09c5c4941064eb27e..cb26513a466e0b149731518cd0021bece8943c66 100644
--- a/libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java
+++ b/libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java
@@ -45,6 +45,8 @@ public class Application extends android.app.Application
AdblockHelper
.get()
.init(this, basePath, true, AdblockHelper.PREFERENCE_NAME)
- .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map);
+ .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map)
+ .setApplication(getPackageName())
+ .setApplicationVersion("app.version");
sergei 2017/03/31 13:49:09 is "app.version" a correct value? I thought the ex
anton 2017/03/31 13:52:25 it accepts any value as it's just a string
sergei 2017/03/31 14:01:52 Felix, what about server side and statistics scrip
diegocarloslima 2017/03/31 14:07:14 It would be a more intuitive example here to provi
anton 2017/03/31 14:16:08 it's just an example. it's up to app developer to
}
}

Powered by Google App Engine
This is Rietveld