Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29401555: Issue 5088 - Remove code duplicate for refresh subscriptions (Closed)

Created:
April 3, 2017, 6:13 a.m. by anton
Modified:
April 28, 2017, 10:22 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5088 - Remove code duplicate for refresh subscriptions

Patch Set 1 #

Total comments: 4

Patch Set 2 : using "update" instead of "refresh" terminology #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 1 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 7
anton
https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java (left): https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#oldcode46 libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java:46: import android.content.pm.PackageManager.NameNotFoundException; not related by the task, but desired ...
April 3, 2017, 6:17 a.m. (2017-04-03 06:17:54 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java (left): https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#oldcode254 libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java:254: private static final int UPDATE_DELAY_MS = 1 * 1000; ...
April 7, 2017, 9:36 a.m. (2017-04-07 09:36:54 UTC) #2
anton
On 2017/04/07 09:36:54, diegocarloslima wrote: > https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java > File > libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java > (left): > > ...
April 7, 2017, 9:37 a.m. (2017-04-07 09:37:57 UTC) #3
diegocarloslima
On 2017/04/07 09:37:57, anton wrote: > On 2017/04/07 09:36:54, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java ...
April 7, 2017, 12:47 p.m. (2017-04-07 12:47:25 UTC) #4
Felix Dahlke
Looks good, but I guess it'll need some changing after my comment. https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java ...
April 10, 2017, 11:59 a.m. (2017-04-10 11:59:47 UTC) #5
anton
On 2017/04/10 11:59:47, Felix Dahlke wrote: > Looks good, but I guess it'll need some ...
April 13, 2017, 9:37 a.m. (2017-04-13 09:37:21 UTC) #6
Felix Dahlke
April 28, 2017, 9:18 a.m. (2017-04-28 09:18:14 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld