Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(799)

Issue 29401555: Issue 5088 - Remove code duplicate for refresh subscriptions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by anton
Modified:
3 months, 3 weeks ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5088 - Remove code duplicate for refresh subscriptions

Patch Set 1 #

Total comments: 4

Patch Set 2 : using "update" instead of "refresh" terminology #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 1 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 7
anton
https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java (left): https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#oldcode46 libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java:46: import android.content.pm.PackageManager.NameNotFoundException; not related by the task, but desired ...
4 months, 3 weeks ago (2017-04-03 06:17:54 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java (left): https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#oldcode254 libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java:254: private static final int UPDATE_DELAY_MS = 1 * 1000; ...
4 months, 2 weeks ago (2017-04-07 09:36:54 UTC) #2
anton
On 2017/04/07 09:36:54, diegocarloslima wrote: > https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java > File > libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java > (left): > > ...
4 months, 2 weeks ago (2017-04-07 09:37:57 UTC) #3
diegocarloslima
On 2017/04/07 09:37:57, anton wrote: > On 2017/04/07 09:36:54, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java ...
4 months, 2 weeks ago (2017-04-07 12:47:25 UTC) #4
Felix Dahlke
Looks good, but I guess it'll need some changing after my comment. https://codereview.adblockplus.org/29401555/diff/29401556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java ...
4 months, 2 weeks ago (2017-04-10 11:59:47 UTC) #5
anton
On 2017/04/10 11:59:47, Felix Dahlke wrote: > Looks good, but I guess it'll need some ...
4 months, 1 week ago (2017-04-13 09:37:21 UTC) #6
Felix Dahlke
3 months, 3 weeks ago (2017-04-28 09:18:14 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5