Issue 5113 - Adds support for json files to packagerChrome in top level dir

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import io
 import json
 import os
 import re
 from StringIO import StringIO
 import struct
 import sys
 import collections
 
 from packager import (readMetadata, getDefaultFileName, getBuildVersion,
                       getTemplate, Files)
 
 defaultLocale = 'en_US'
 
 
 def getIgnoredFiles(params):
     return {'store.description'}
 
 
 def getPackageFiles(params):
-    result = set(('_locales', 'icons', 'jquery-ui', 'lib', 'skin', 'ui', 'ext'))
+    result = {'_locales', 'icons', 'jquery-ui', 'lib', 'skin', 'ui', 'ext'}
 
     if params['devenv']:
         result.add('qunit')
 
     baseDir = params['baseDir']
 
     for file in os.listdir(baseDir):
         if os.path.splitext(file)[1] in {'.json', '.js', '.html', '.xml'}:

[Sebastian Noack, 2017/04/06 11:36:12]

Nice, that is exactly how I wanted to change this code anyway. Perhaps, while on
it, also use a set literal when initializing the "result" variable above?

[Jon Sonesen, 2017/04/06 12:05:46]

Awesome,

Done.

             result.add(file)
     return result
 
 
 def processFile(path, data, params):
     # We don't change anything yet, this function currently only exists here so
     # that it can be overridden if necessary.
     return data
 
 
@@ skipping 351 matching lines @@
         files['qunit/index.html'] = createScriptPage(params, 'testIndex.html.tmpl',
                                                      ('general', 'testScripts'))
 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)