Issue 5113 - Adds support for json files to packagerChrome in top level dir

Issue 5113 - Adds support for json files to packagerChrome in top level dir

[Sebastian Noack, 2017-04-06 11:36:12]

https://codereview.adblockplus.org/29404598/diff/29404599/packagerChrome.py
File packagerChrome.py (right):

https://codereview.adblockplus.org/29404598/diff/29404599/packagerChrome.py#n...
packagerChrome.py:34: if os.path.splitext(file)[1] in {'.json', '.js', '.html',
'.xml'}:
Nice, that is exactly how I wanted to change this code anyway. Perhaps, while on
it, also use a set literal when initializing the "result" variable above?

[Jon Sonesen, 2017-04-06 12:05:46]

I also added the .cache dir which pytest creates when tests fail to th ignore
files.

https://codereview.adblockplus.org/29404598/diff/29404599/packagerChrome.py
File packagerChrome.py (right):

https://codereview.adblockplus.org/29404598/diff/29404599/packagerChrome.py#n...
packagerChrome.py:34: if os.path.splitext(file)[1] in {'.json', '.js', '.html',
'.xml'}:
On 2017/04/06 11:36:12, Sebastian Noack wrote:
> Nice, that is exactly how I wanted to change this code anyway. Perhaps, while
on
> it, also use a set literal when initializing the "result" variable above?
Awesome,

Done.

[Sebastian Noack, 2017-04-06 12:11:07]

On 2017/04/06 12:05:46, Jon Sonesen wrote:
> I also added the .cache dir which pytest creates when tests fail to th ignore
> files.

This seems somewhat unrelated. Also I'm not sure whether it wouldn't even be
preferable to not ignore the .cache dir, as it seem to be something you would
want to get rid of when running "hg clean". How do we handle it in other
repositories?

[Jon Sonesen, 2017-04-06 12:13:46]

On 2017/04/06 12:11:07, Sebastian Noack wrote:
> On 2017/04/06 12:05:46, Jon Sonesen wrote:
> > I also added the .cache dir which pytest creates when tests fail to th
ignore
> > files.
> 
> This seems somewhat unrelated. Also I'm not sure whether it wouldn't even be
> preferable to not ignore the .cache dir, as it seem to be something you would
> want to get rid of when running "hg clean". How do we handle it in other
> repositories?

Yeah I am happy to not add it but everywhere else we ignore it, so thought it
would be ok.

[Sebastian Noack, 2017-04-06 12:27:30]

On 2017/04/06 12:13:46, Jon Sonesen wrote:
> On 2017/04/06 12:11:07, Sebastian Noack wrote:
> > On 2017/04/06 12:05:46, Jon Sonesen wrote:
> > > I also added the .cache dir which pytest creates when tests fail to th
> ignore
> > > files.
> > 
> > This seems somewhat unrelated. Also I'm not sure whether it wouldn't even be
> > preferable to not ignore the .cache dir, as it seem to be something you
would
> > want to get rid of when running "hg clean". How do we handle it in other
> > repositories?
> 
> Yeah I am happy to not add it but everywhere else we ignore it, so thought it
> would be ok.

In fact, we have it in sitecript and cms as well. I guess we could it add in
buildtools as well then. But please to so with a separate (noissue) patch. Also
it seems the .gitignore in the cms is out of sync, the .cache folder isn't
ignored there, but in the respective .hgignore.

[Jon Sonesen, 2017-04-06 12:28:41]

On 2017/04/06 12:27:30, Sebastian Noack wrote:
> On 2017/04/06 12:13:46, Jon Sonesen wrote:
> > On 2017/04/06 12:11:07, Sebastian Noack wrote:
> > > On 2017/04/06 12:05:46, Jon Sonesen wrote:
> > > > I also added the .cache dir which pytest creates when tests fail to th
> > ignore
> > > > files.
> > > 
> > > This seems somewhat unrelated. Also I'm not sure whether it wouldn't even
be
> > > preferable to not ignore the .cache dir, as it seem to be something you
> would
> > > want to get rid of when running "hg clean". How do we handle it in other
> > > repositories?
> > 
> > Yeah I am happy to not add it but everywhere else we ignore it, so thought
it
> > would be ok.
> 
> In fact, we have it in sitecript and cms as well. I guess we could it add in
> buildtools as well then. But please to so with a separate (noissue) patch.
Also
> it seems the .gitignore in the cms is out of sync, the .cache folder isn't
> ignored there, but in the respective .hgignore.

Ok, great. I am happy to submit noissue patches to update those, but first ill
remove the changes from this patch.
Thanks

[Sebastian Noack, 2017-04-07 12:32:39]

LGTM