Noissue - release mutex before call of notify_one

src/DefaultTimer.cpp

 /*
 * This file is part of Adblock Plus <https://adblockplus.org/>,
 * Copyright (C) 2006-2017 eyeo GmbH
 *
 * Adblock Plus is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 3 as
 * published by the Free Software Foundation.
 *
 * Adblock Plus is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
   }
   conditionVariable.notify_one();
   if (m_thread.joinable())
     m_thread.join();
 }
 
 void DefaultTimer::SetTimer(const std::chrono::milliseconds& timeout, const TimerCallback& timerCallback)
 {
   if (!timerCallback)
     return;
-  std::lock_guard<std::mutex> lock(mutex);
-  TimerUnit timer = { std::chrono::steady_clock::now() + timeout, timerCallback };
-  timers.push(timer);
+  {
+    std::lock_guard<std::mutex> lock(mutex);
+    TimerUnit timer = { std::chrono::steady_clock::now() + timeout, timerCallback };
+    timers.push(timer);
+  }
   conditionVariable.notify_one();
 }
 
 void DefaultTimer::ThreadFunc()
 {
   while (true)
   {
     std::unique_lock<std::mutex> lock(mutex);
     if (timers.empty())
     {
@@ skipping 20 matching lines @@
       catch (...)
       {
         // do nothing, but the thread will be alive.
       }
       lock.lock();
     }
     if (shouldThreadStop)
       return;
   }
 }