Issue 29404610: Noissue - release mutex before call of notify_one

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29404610: Noissue - release mutex before call of notify_one (Closed)

Created:
April 6, 2017, 2:05 p.m. by sergei

Modified:
April 6, 2017, 4:45 p.m.

Reviewers:
hub

CC:
Felix Dahlke, Oleksandr, Eric

Visibility:
Public.

Description

It makes no sense to keep this mutex acquired because std::condition_variable does not require it and it can cause unnecessary waiting in the worker thread, namely that thread can wake up and be immediately blocked on the mutex which is not released yet. https://codereview.adblockplus.org/29404610/

Patch Set 1 #

Created: April 6, 2017, 2:05 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/DefaultTimer.cpp	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages