Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29408747: Issue 5013 - Mark more method as const (Closed)

Created:
April 10, 2017, 3:08 p.m. by hub
Modified:
April 11, 2017, 11:58 a.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 5013 - Mark more method as const

Patch Set 1 #

Total comments: 2

Patch Set 2 : Isolate::Get() and JsEngine::GetIsolate() should be non-const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M include/AdblockPlus/FilterEngine.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/FilterEngine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/JsEngine.cpp View 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6
hub
April 10, 2017, 3:09 p.m. (2017-04-10 15:09:01 UTC) #1
hub
I think this patch should be the last round for issue 5013.
April 10, 2017, 3:31 p.m. (2017-04-10 15:31:43 UTC) #2
sergei
https://codereview.adblockplus.org/29408747/diff/29408748/include/AdblockPlus/JsEngine.h File include/AdblockPlus/JsEngine.h (right): https://codereview.adblockplus.org/29408747/diff/29408748/include/AdblockPlus/JsEngine.h#newcode68 include/AdblockPlus/JsEngine.h:68: v8::Isolate* Get() const I would like to not make ...
April 11, 2017, 10:36 a.m. (2017-04-11 10:36:50 UTC) #3
hub
https://codereview.adblockplus.org/29408747/diff/29408748/include/AdblockPlus/JsEngine.h File include/AdblockPlus/JsEngine.h (right): https://codereview.adblockplus.org/29408747/diff/29408748/include/AdblockPlus/JsEngine.h#newcode68 include/AdblockPlus/JsEngine.h:68: v8::Isolate* Get() const On 2017/04/11 10:36:50, sergei wrote: > ...
April 11, 2017, 11:32 a.m. (2017-04-11 11:32:35 UTC) #4
hub
updated patch
April 11, 2017, 11:45 a.m. (2017-04-11 11:45:39 UTC) #5
sergei
April 11, 2017, 11:51 a.m. (2017-04-11 11:51:57 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld