Issue 29409617: Issue 5157 - Update dependency on adblockpluscore to revision 66bcf4dca35a

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29409617: Issue 5157 - Update dependency on adblockpluscore to revision 66bcf4dca35a (Closed)

Created:
April 11, 2017, 3:17 p.m. by Wladimir Palant

Modified:
April 20, 2017, 12:54 p.m.

Reviewers:
kzar

CC:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockplus

Visibility:
Public.

Patch Set 2 : Finalized patch #

Total comments: 3

Created: April 20, 2017, 8:46 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -86 lines)			Patch
M	dependencies	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/io.js	View		1 chunk	+135 lines, -77 lines	3 comments	Download
M	lib/prefs.json	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/utils.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Wladimir Palant

Uploaded Patch Set 2, this is now the final version. I only had to change ...

April 20, 2017, 8:49 a.m. (2017-04-20 08:49:21 UTC) #2

kzar

Otherwise LGTM https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js#newcode164 lib/io.js:164: if (error == "NoSuchFile") It seems like ...

April 20, 2017, 10:25 a.m. (2017-04-20 10:25:08 UTC) #3

Wladimir Palant

https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js#newcode164 lib/io.js:164: if (error == "NoSuchFile") On 2017/04/20 10:25:07, kzar wrote: ...

April 20, 2017, 12:02 p.m. (2017-04-20 12:02:06 UTC) #4

kzar

April 20, 2017, 12:11 p.m. (2017-04-20 12:11:59 UTC) #5

https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js
File lib/io.js (right):

https://codereview.adblockplus.org/29409617/diff/29418567/lib/io.js#newcode164
lib/io.js:164: if (error == "NoSuchFile")
On 2017/04/20 12:02:06, Wladimir Palant wrote:
> On 2017/04/20 10:25:07, kzar wrote:
> > It seems like this pattern is repeated quite a bit, could you abstract it?
> 
> I thought about it but couldn't see a way requiring less complexity than there
> is right now. Do you have any suggestions?

Hmm I guess not. I didn't realise the arguments passed to callLegacy vary
slightly. Fair enough.

Expand All Messages | Collapse All Messages