Unified Diff: test/JsEngine.cpp
Issue 29410664:
Issue 5013 - Use const JsValue and pass reference where applicable (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove the SetProperty() changes.
Created April 13, 2017, 1:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« include/AdblockPlus/JsValue.h ('K')
|
« test/FilterEngine.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/JsEngine.cpp |
| =================================================================== |
| --- a/test/JsEngine.cpp |
| +++ b/test/JsEngine.cpp |
| @@ -62,19 +62,19 @@ |
| value = jsEngine->NewObject(); |
| ASSERT_TRUE(value->IsObject()); |
| ASSERT_EQ(0u, value->GetOwnPropertyNames().size()); |
| } |
| TEST_F(JsEngineTest, EventCallbacks) |
| { |
| bool callbackCalled = false; |
| - AdblockPlus::JsValueList callbackParams; |
| + AdblockPlus::JsConstValueList callbackParams; |
| auto Callback = [&callbackCalled, & callbackParams]( |
| - const AdblockPlus::JsValueList& params) |
| + const AdblockPlus::JsConstValueList& params) |
| { |
| callbackCalled = true; |
| callbackParams = params; |
| }; |
| // Trigger event without a callback |
| callbackCalled = false; |
| jsEngine->Evaluate("_triggerEvent('foobar')"); |
« include/AdblockPlus/JsValue.h ('K')
|
« test/FilterEngine.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
