Noissue - [emscripten] Address compiler warnings

compile

 #!/usr/bin/env python
 
 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-2017 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 23 matching lines @@
     'ALLOW_MEMORY_GROWTH': 1,
     'NO_EXIT_RUNTIME': 1,
     'NO_DYNAMIC_EXECUTION': 1,
     'NO_FILESYSTEM': 1,
     'INVOKE_RUN': 0,
     'TEXTDECODER': 0,
     'EXPORTED_RUNTIME_METHODS': ['cwrap', 'ccall', 'stringToAscii'],
 }
 DEFINES = []
 ADDITIONAL_PARAMS = ['-O3', '-m32', '-std=gnu++14', '--memory-init-file', '0',
-                     '--emit-symbol-map']
+                     '--emit-symbol-map', '-Wall', '-Werror']

[hub, 2017/04/13 15:52:49]

I'm always skeptical about -Werror because it cause build to break when using
different compilers. But I do love 0 warning builds.

[sergei, 2017/04/13 16:58:14]

I have the same opinion, though in this case the compiler is defined so far.
From the top of the head I highly recommend to add -pedantic, it can be another
commit.

[Wladimir Palant, 2017/04/13 18:35:43]

The compiler is fixed, which is why we have more freedom here. And without
-Werror people tend to ignore warnings, to the point where there are too many to
notice new ones.

On 2017/04/13 16:58:14, sergei wrote:
It breaks EM_ASM because of -Wdollar-in-identifier-extension, no other warnings
beyond that. So maybe some other time.

 
 
 def get_source_files(phase):
     for (path, dirs, files) in os.walk(SOURCE_DIR):
         for f in files:
             if os.path.splitext(f)[1] != '.cpp':
                 continue
             if (
                 phase != 'bindings' and
                 os.path.basename(path) == 'bindings' and
@@ skipping 65 matching lines @@
     parser.add_argument(
         '-t', '--tracing',
         action='store_true',
         help='Enable memory tracing'
     )
     args = parser.parse_args()
 
     env = getenv(args.emscripten_config)
     generate_bindings(env)
     run_compiler(env, debug=args.debug, tracing=args.tracing)