Issue 29411657: Noissue - [emscripten] Address compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29411657: Noissue - [emscripten] Address compiler warnings (Closed)

Created:
April 13, 2017, 3:46 p.m. by Wladimir Palant

Modified:
April 13, 2017, 6:37 p.m.

Reviewers:
sergei, hub

CC:
Felix Dahlke

Base URL:
https://hg.adblockplus.org/adblockpluscore

Visibility:
Public.

Description

Apparently, I had to enable compiler warnings explicitly - this is done now. All warnings have been addressed, and I verified that exactly the same build is still being produced with these changes.

Patch Set 1 #

Total comments: 3

Created: April 13, 2017, 3:46 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	compile	View	1 chunk	+1 line, -1 line	3 comments	Download
M	compiled/String.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiled/StringMap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiled/filter/ActiveFilter.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiled/filter/Filter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiled/subscription/Subscription.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hub

(just a concern, I can live with it) https://codereview.adblockplus.org/29411657/diff/29411658/compile File compile (right): https://codereview.adblockplus.org/29411657/diff/29411658/compile#newcode44 compile:44: '--emit-symbol-map', ...

April 13, 2017, 3:52 p.m. (2017-04-13 15:52:49 UTC) #2

sergei

LGTM https://codereview.adblockplus.org/29411657/diff/29411658/compile File compile (right): https://codereview.adblockplus.org/29411657/diff/29411658/compile#newcode44 compile:44: '--emit-symbol-map', '-Wall', '-Werror'] On 2017/04/13 15:52:49, hub wrote: ...

April 13, 2017, 4:58 p.m. (2017-04-13 16:58:14 UTC) #3

Wladimir Palant

April 13, 2017, 6:35 p.m. (2017-04-13 18:35:43 UTC) #4

https://codereview.adblockplus.org/29411657/diff/29411658/compile
File compile (right):

https://codereview.adblockplus.org/29411657/diff/29411658/compile#newcode44
compile:44: '--emit-symbol-map', '-Wall', '-Werror']
On 2017/04/13 15:52:49, hub wrote:
> I'm always skeptical about -Werror because it cause build to break when using
> different compilers. But I do love 0 warning builds.

The compiler is fixed, which is why we have more freedom here. And without
-Werror people tend to ignore warnings, to the point where there are too many to
notice new ones.

On 2017/04/13 16:58:14, sergei wrote:
> From the top of the head I highly recommend to add -pedantic, it can be
another
> commit.

It breaks EM_ASM because of -Wdollar-in-identifier-extension, no other warnings
beyond that. So maybe some other time.

Expand All Messages | Collapse All Messages