Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29412555: Issue 5140 - Add tests for settings storage (Closed)

Created:
April 14, 2017, 8:02 a.m. by anton
Modified:
Oct. 30, 2018, 7:47 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5140 - Add tests for settings storage

Patch Set 1 #

Total comments: 6

Messages

Total messages: 2
anton
https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java (right): https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java#newcode30 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java:30: private volatile boolean adblockEnabled; actually it's a bug fix! ...
April 14, 2017, 8:14 a.m. (2017-04-14 08:14:01 UTC) #1
anton
April 14, 2017, 8:15 a.m. (2017-04-14 08:15:09 UTC) #2
https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-andr...
File
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java
(right):

https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-andr...
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java:30:
private volatile boolean adblockEnabled;
though the bug did not appear as we don't serialize it in fragments

Powered by Google App Engine
This is Rietveld