Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 29412555: Issue 5140 - Add tests for settings storage

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by anton
Modified:
3 months, 1 week ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5140 - Add tests for settings storage

Patch Set 1 #

Total comments: 6

Messages

Total messages: 2
anton
https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java (right): https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java#newcode30 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java:30: private volatile boolean adblockEnabled; actually it's a bug fix! ...
3 months, 1 week ago (2017-04-14 08:14:01 UTC) #1
anton
3 months, 1 week ago (2017-04-14 08:15:09 UTC) #2
https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-andr...
File
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java
(right):

https://codereview.adblockplus.org/29412555/diff/29412556/libadblockplus-andr...
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java:30:
private volatile boolean adblockEnabled;
though the bug did not appear as we don't serialize it in fragments
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5