libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java - Issue 29412555: Issue 5140 - Add tests for settings storage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

Issue 29412555: Issue 5140 - Add tests for settings storage (Closed)

Patch Set: Created April 14, 2017, 8:02 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

index e0fbd539ce6d334aec272008697d646d280cc0fb..01a65da956f560da3c70f6cb562ecbb955408aa7 100644

--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

@@ -27,8 +27,8 @@ import java.util.List;

public class AdblockSettings implements Serializable

{

- private transient boolean adblockEnabled;

- private transient Boolean acceptableAdsEnabled;

+ private volatile boolean adblockEnabled;

anton 2017/04/14 08:14:00 actually it's a bug fix! this was meant to be `vol

anton 2017/04/14 08:15:09 though the bug did not appear as we don't serializ

+ private volatile boolean acceptableAdsEnabled;

anton 2017/04/14 08:14:00 decided to make it primitive. The original intenti

private List<Subscription> subscriptions;

private List<String> whitelistedDomains;

private ConnectionType allowedConnectionType;

« no previous file with comments | « libadblockplus-android-settings/pom.xml ('k') | libadblockplus-android-tests/build.gradle » ('j') | libadblockplus-android-tests/build.gradle » ('J')