Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(694)

Issue 29413555: Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by anton
Modified:
7 hours, 30 minutes ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

Patch Set 1 #

Total comments: 4

Messages

Total messages: 2
anton
https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java (left): https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java#oldcode34 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java:34: public IsAllowedConnectionCallbackImpl(Context context) minor change (taking into account law ...
1 week, 5 days ago (2017-04-15 13:58:03 UTC) #1
diegocarloslima
7 hours, 30 minutes ago (2017-04-27 19:04:59 UTC) #2
Looks good, but I think is a good practice to declare inner classes as static
wherever possible, in order to avoid unnecessary exposure of the outer class,
that might cause leaks.

https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java
(right):

https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java:37:
private class TestRequest extends AndroidWebRequest
This inner class can be static

https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java:54:
private class TestCallback extends IsAllowedConnectionCallback
This inner class can be static
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5